From: Jiri Kosina <jikos@kernel.org>
To: Guohua Zhong <ghzhong@yifangdigital.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Dmitry Torokhov <dtor@chromium.org>,
Benson Leung <bleung@chromium.org>,
Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown
Date: Tue, 21 Jun 2016 13:09:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1606211308590.6874@cbobk.fhfr.pm> (raw)
In-Reply-To: <1466504865-19907-1-git-send-email-ghzhong@yifangdigital.com>
On Tue, 21 Jun 2016, Guohua Zhong wrote:
> Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
> irq before device shutdown.
>
> Some HW design (i.e. Umaro, a chromebook model) is that the power to
> i2c hid device won't down after device shutdown. Also the i2c-hid driver
> do not send suspend cmd to the hid i2c device and free its irq before
> shutdown.So if We touch the touchscreen or some other i2c hid device,
> the power consumtion will be go up even when the device is in shutdown
> state.
>
> Though the root cause maybe a HW issue. But it seems that it is a
> good pratice to set power sleep for i2c-hid device before shutdown.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-06-21 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 10:27 Guohua Zhong
2016-06-21 11:09 ` Jiri Kosina [this message]
2016-06-22 11:15 ` ghzhong
2016-06-22 11:23 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1606211308590.6874@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=ghzhong@yifangdigital.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®