From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
Chunyu Hu <chuhu@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific
Date: Fri, 26 Aug 2016 11:05:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1608261105080.462@pobox.suse.cz> (raw)
In-Reply-To: <cfba2c823bb984690b73572aaae1db596b54a082.1472137475.git.jpoimboe@redhat.com>
On Thu, 25 Aug 2016, Josh Poimboeuf wrote:
> There's no reliable way to determine which module tainted the kernel
> with TAINT_LIVEPATCH. For example, /sys/module/<klp module>/taint
> doesn't report it. Neither does the "mod -t" command in the crash tool.
>
> Make it crystal clear who the guilty party is by associating
> TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo
> attribute. The flag will still get set in the kernel like before, but
> now it also sets the same flag in mod->taint.
>
> Note that now the taint flag gets set when the module is loaded rather
> than when it's enabled.
>
> I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to
> better reflect its purpose: it's basically a livepatch-specific
> sub-function of check_modinfo().
>
> Reported-by: Chunyu Hu <chuhu@redhat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Miroslav
next prev parent reply other threads:[~2016-08-26 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 15:04 Josh Poimboeuf
2016-08-25 15:11 ` Petr Mladek
2016-08-26 9:05 ` Miroslav Benes [this message]
2016-08-26 12:50 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1608261105080.462@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=chuhu@redhat.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®