From: Finn Thain <fthain@telegraphics.com.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ondrej Zary <linux@rainbow-software.org>,
Hannes Reinecke <hare@suse.com>, Hannes Reinicke <hare@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency
Date: Wed, 19 Oct 2016 09:27:34 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1610190912580.10204@nippy.intranet> (raw)
In-Reply-To: <20161018151827.2729976-1-arnd@arndb.de>
On Tue, 18 Oct 2016, Arnd Bergmann wrote:
> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
>
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
>
> This adds a Kconfig dependency.
>
> Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 98451fe031a4..3b416c9efe5e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -744,7 +744,7 @@ config SCSI_ISCI
>
> config SCSI_GENERIC_NCR5380
> tristate "Generic NCR5380/53c400 SCSI ISA card support"
> - depends on ISA && SCSI
> + depends on ISA && SCSI && HAS_IOPORT_MAP
> select SCSI_SPI_ATTRS
> ---help---
> This is a driver for old ISA card SCSI controllers based on a
>
next prev parent reply other threads:[~2016-10-18 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 15:18 Arnd Bergmann
2016-10-18 22:27 ` Finn Thain [this message]
2016-10-19 1:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1610190912580.10204@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=arnd@arndb.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®