[PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

[PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

[Andreas Theodosiou]

This is a patch to the fb_ili9163.c file that inserts a line break in
line #92 to make the line fit into the 80 character limit.

Signed-off-by: Andreas Theodosiou <andreasabu@gmail.com>
---
 drivers/staging/fbtft/fb_ili9163.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c
index ed92a64..fc7568b 100644
--- a/drivers/staging/fbtft/fb_ili9163.c
+++ b/drivers/staging/fbtft/fb_ili9163.c
@@ -89,7 +89,8 @@
 
 /*
 This display:
-http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
+http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
+Color-TFT-LCD-Display-Module-/271422122271
 This particular display has a design error! The controller has 3 pins to
 configure to constrain the memory and resolution to a fixed dimension (in
 that case 128x128) but they leaved those pins configured for 128x160 so
-- 
2.3.5

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

[Joe Perches]

On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
[]
> diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c
[]
> @@ -89,7 +89,8 @@
>  
>  /*
>  This display:
> -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
> +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
> +Color-TFT-LCD-Display-Module-/271422122271

Please don't do this to links.

There are many real defects to fix and other code to improve.

This isn't one of those.

I doubt though that an ebay link is very long lasting.

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

[Giedrius Statkevičius]

On Sat, 4 Apr 2015, Andreas Theodosiou wrote:

> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
> 
> Signed-off-by: Andreas Theodosiou <andreasabu@gmail.com>
> ---
>  drivers/staging/fbtft/fb_ili9163.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c
> index ed92a64..fc7568b 100644
> --- a/drivers/staging/fbtft/fb_ili9163.c
> +++ b/drivers/staging/fbtft/fb_ili9163.c
> @@ -89,7 +89,8 @@
>  
>  /*
>  This display:
> -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
> +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
> +Color-TFT-LCD-Display-Module-/271422122271

With this change the user won't be able to just simply click on the url and have
it open for him. Thus I don't think this is a good change. Sometimes in the
kernel people leave lines over 80 characters to make the code more grep-able,
sometimes it's just more clear when it's over 80 characters or, probably, in
cases like this.

Su pagarba / Regards,
Giedrius