mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: akpm@linux-foundation.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com
Subject: Re: [TOMOYO #14 (mmotm 2008-12-30-16-05) 02/10] Singly linked list implementation.
Date: Tue, 6 Jan 2009 20:11:00 +1100 (EST)	[thread overview]
Message-ID: <alpine.LRH.1.10.0901062008480.25091@tundra.namei.org> (raw)
In-Reply-To: <200901060813.n068DI3Y023188@www262.sakura.ne.jp>

On Tue, 6 Jan 2009, Tetsuo Handa wrote:

> 
> James Morris wrote:
> > This has a technical ack from Paul, but what about Linus' long-standing 
> > objection to singly-linked lists in the kernel?  I'm sure this has been 
> > discussed re. your patches, but I can't find a reference.
> I couldn't find one neither. (What does "re." mean?)

http://en.wiktionary.org/wiki/re#Etymology_1

> But optimistically speaking, there are many in-tree users who define "struct"
> without "prev" pointer.
> 
>   # grep -hr 'struct [a-zA-Z0-9_]* \*next;' linux-2.6.28/include/linux/ | wc -l
>   42
>   # grep -hr 'struct [a-zA-Z0-9_]* \*prev;' linux-2.6.28/include/linux/ | wc -l
>   7
> 
> Not all structures listed below are used as singly linked list,
> but many of them are used as singly linked list.

Can any of these be converted to your singly linked list implementation ?

> 
>   struct sched_class;
>   struct acpi_pci_driver;
>   struct adb_request;
>   struct atalk_route;
>   struct core_thread;
>   struct dma_async_tx_descriptor;
>   struct erase_info;
>   struct esp_pio_buffer;
>   struct fdtable;
>   struct floppy_raw_cmd;
>   struct ftrace_ops;
>   struct hdlc_proto;
>   struct hwif_s;
>   struct ippp_buf_queue;
>   struct irqaction;
>   struct isdn_net_local_s;
>   struct kcore_list;
>   struct mfc6_cache;
>   struct mfc_cache;
>   struct nls_table;
>   struct notifier_block;
>   struct page_list;
>   struct pbe;
>   struct phone_device;
>   struct pnp_id;
>   struct r3964_block_header;
>   struct r3964_client_info;
>   struct r3964_message;
>   struct rcu_head;
>   struct resource_list;
>   struct sched_group;
>   struct sdio_func_tuple;
>   struct tasklet_struct;
>   struct tty_buffer;
>   struct xor_block_template;
> 
> Thus, I believe it is acceptable that TOMOYO uses singly linked list
> unless Linus comes out and yell "No!".

He's yelled no in the past, so there needs to be a convincing argument 
which he'll accept.


- James
-- 
James Morris
<jmorris@namei.org>

  reply	other threads:[~2009-01-06  9:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-01  5:07 [TOMOYO #14 (mmotm 2008-12-30-16-05) 00/10] TOMOYO Linux Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 01/10] Add in_execve flag into task_struct Tetsuo Handa
2009-01-05  8:25   ` James Morris
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 02/10] Singly linked list implementation Tetsuo Handa
2009-01-05  9:07   ` James Morris
2009-01-06  8:13     ` Tetsuo Handa
2009-01-06  9:11       ` James Morris [this message]
2009-01-07  6:36         ` Tetsuo Handa
2009-01-07 19:09           ` Serge E. Hallyn
2009-01-08  6:19             ` Tetsuo Handa
2009-01-14  8:57     ` Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 03/10] Introduce d_realpath() Tetsuo Handa
2009-01-05  9:08   ` James Morris
2009-01-14  8:58     ` Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 04/10] Memory and pathname management functions Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 05/10] Common functions for TOMOYO Linux Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 06/10] File operation restriction part Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 07/10] Domain transition handler Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 08/10] LSM adapter functions Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 09/10] Kconfig and Makefile Tetsuo Handa
2009-01-01  5:07 ` [TOMOYO #14 (mmotm 2008-12-30-16-05) 10/10] MAINTAINERS info Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.1.10.0901062008480.25091@tundra.namei.org \
    --to=jmorris@namei.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®