From: James Morris <jmorris@namei.org>
To: Eric Paris <eparis@redhat.com>
Cc: zohar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IMA: remove read permissions on the ima policy file
Date: Fri, 15 May 2009 10:40:23 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.00.0905151040140.5643@tundra.namei.org> (raw)
In-Reply-To: <20090512191355.6874.31248.stgit@dhcp231-142.rdu.redhat.com>
On Tue, 12 May 2009, Eric Paris wrote:
> The IMA policy file does not implement read. Trying to just open/read/close
> the file will load a blank policy and you cannot then change the policy
> without a reboot. This removes the read permission from the file so one must
> at least be attempting to write...
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
> ---
>
> security/integrity/ima/ima_fs.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
> index 510186f..2a829da 100644
> --- a/security/integrity/ima/ima_fs.c
> +++ b/security/integrity/ima/ima_fs.c
> @@ -15,6 +15,7 @@
> * implemenents security file system for reporting
> * current measurement list and IMA statistics
> */
> +#include <linux/fcntl.h>
> #include <linux/module.h>
> #include <linux/seq_file.h>
> #include <linux/rculist.h>
> @@ -283,6 +284,9 @@ static atomic_t policy_opencount = ATOMIC_INIT(1);
> */
> int ima_open_policy(struct inode * inode, struct file * filp)
> {
> + /* No point in being allowed to open it if you aren't going to write */
> + if (!(filp->f_flags & O_WRONLY))
> + return -EACCES;
> if (atomic_dec_and_test(&policy_opencount))
> return 0;
> return -EBUSY;
> @@ -349,7 +353,7 @@ int ima_fs_init(void)
> goto out;
>
> ima_policy = securityfs_create_file("policy",
> - S_IRUSR | S_IRGRP | S_IWUSR,
> + S_IWUSR,
> ima_dir, NULL,
> &ima_measure_policy_ops);
> if (IS_ERR(ima_policy))
>
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2009-05-15 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 19:13 Eric Paris
2009-05-14 13:11 ` Mimi Zohar
2009-05-15 0:40 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.0905151040140.5643@tundra.namei.org \
--to=jmorris@namei.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®