mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Eric Paris <eparis@redhat.com>
Cc: jmorris@namei.org, linux-kernel@vger.kernel.org,
	David Safford <safford@watson.ibm.com>
Subject: Re: [PATCH] IMA: remove read permissions on the ima policy file
Date: Thu, 14 May 2009 09:11:19 -0400	[thread overview]
Message-ID: <1242306679.4647.5.camel@dyn9002018117.watson.ibm.com> (raw)
In-Reply-To: <20090512191355.6874.31248.stgit@dhcp231-142.rdu.redhat.com>

On Tue, 2009-05-12 at 15:13 -0400, Eric Paris wrote:
> The IMA policy file does not implement read.  Trying to just open/read/close
> the file will load a blank policy and you cannot then change the policy
> without a reboot.  This removes the read permission from the file so one must
> at least be attempting to write...
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>

Acked-by: Mimi Zohar <zohar@us.ibm.com>

> ---
> 
>  security/integrity/ima/ima_fs.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
> index 510186f..2a829da 100644
> --- a/security/integrity/ima/ima_fs.c
> +++ b/security/integrity/ima/ima_fs.c
> @@ -15,6 +15,7 @@
>   *	implemenents security file system for reporting
>   *	current measurement list and IMA statistics
>   */
> +#include <linux/fcntl.h>
>  #include <linux/module.h>
>  #include <linux/seq_file.h>
>  #include <linux/rculist.h>
> @@ -283,6 +284,9 @@ static atomic_t policy_opencount = ATOMIC_INIT(1);
>   */
>  int ima_open_policy(struct inode * inode, struct file * filp)
>  {
> +	/* No point in being allowed to open it if you aren't going to write */
> +	if (!(filp->f_flags & O_WRONLY))
> +		return -EACCES;
>  	if (atomic_dec_and_test(&policy_opencount))
>  		return 0;
>  	return -EBUSY;
> @@ -349,7 +353,7 @@ int ima_fs_init(void)
>  		goto out;
> 
>  	ima_policy = securityfs_create_file("policy",
> -					    S_IRUSR | S_IRGRP | S_IWUSR,
> +					    S_IWUSR,
>  					    ima_dir, NULL,
>  					    &ima_measure_policy_ops);
>  	if (IS_ERR(ima_policy))
> 


  reply	other threads:[~2009-05-14 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12 19:13 Eric Paris
2009-05-14 13:11 ` Mimi Zohar [this message]
2009-05-15  0:40 ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242306679.4647.5.camel@dyn9002018117.watson.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=safford@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®