From: James Morris <jmorris@namei.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Patrick McHardy <kaber@trash.net>,
Andrew Morgan <morgan@kernel.org>,
Vasiliy Kulikov <segoon@openwall.com>,
David Howells <dhowells@redhat.com>, Neil Brown <neilb@suse.de>,
Michal Januszewski <spock@gentoo.org>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH] userns: Replace netlink uses of cap_raised with capable.
Date: Wed, 4 Apr 2012 14:06:19 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.1204041404540.16594@tundra.namei.org> (raw)
In-Reply-To: <m1mx6sz2f2.fsf@fess.ebiederm.org>
On Tue, 3 Apr 2012, Eric W. Biederman wrote:
> In the initial user_namespace the only difference between between
> cap_raised(current_cap(), CAP_SYS_ADMIN) and capable(CAP_SYS_ADMIN)
> are a few sanity checks and the fact that capable(CAP_SYS_ADMIN)
> sets PF_SUPERPRIV if we use the capability.
>
> Since we are going to be using root privilege setting PF_SUPERPRIV
> seems the right thing to do.
Agreed.
Reviewed-by: James Morris <james.l.morris@oracle.com>
- James
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2012-04-04 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 1:55 Eric W. Biederman
2012-04-04 2:26 ` Serge E. Hallyn
2012-04-04 2:45 ` Eric W. Biederman
2012-04-04 4:24 ` Andrew G. Morgan
2012-04-04 4:06 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1204041404540.16594@tundra.namei.org \
--to=jmorris@namei.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=neilb@suse.de \
--cc=philipp.reisner@linbit.com \
--cc=segoon@openwall.com \
--cc=serge@hallyn.com \
--cc=spock@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®