From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@linux-nfs.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] KEYS: Changes for keyrings for security/next
Date: Mon, 22 Sep 2014 22:42:30 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.11.1409222241520.8492@namei.org> (raw)
In-Reply-To: <22597.1411342588@warthog.procyon.org.uk>
On Mon, 22 Sep 2014, David Howells wrote:
> James Morris <jmorris@namei.org> wrote:
>
> > > Can you please pull these changes into security/next. They include the fixes
> > > tag I previously requested as there's a dependency between these changes and
> > > the fixes.
> > >
> >
> > I'm getting this warning after pulling your code:
> >
> > CC crypto/hash_info.o
> > crypto/asymmetric_keys/asymmetric_type.c: In function
> > asymmetric_key_hex_to_key_id:
> > crypto/asymmetric_keys/asymmetric_type.c:110: warning: ignoring return
> > value of hex2bin, declared with attribute warn_unused_result
>
> I've posted an additional patch that moves some of the prevalidation to after
> the memory allocation in asymmetric_key_hex_to_key_id() and added it onto the
> keys-next branch. Here's a revised pull request.
> ---
> Can you please pull these changes into security/next. They include the fixes
> tag I previously requested as there's a dependency between these changes and
> the fixes.
>
Ok, pulled to my next branch.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2014-09-22 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 16:59 David Howells
2014-09-20 2:05 ` James Morris
2014-09-20 12:08 ` David Howells
2014-09-21 23:36 ` David Howells
2014-09-22 12:42 ` James Morris [this message]
2014-09-22 12:53 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1409222241520.8492@namei.org \
--to=jmorris@namei.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®