mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: i865, drm_modeset_lock_all: BUG: unable to handle kernel NULL pointer dereference at 00000104
Date: Tue, 23 Aug 2016 14:46:15 +0300 (EEST)	[thread overview]
Message-ID: <alpine.LRH.2.20.1608231445550.17020@math.ut.ee> (raw)
In-Reply-To: <20160823101054.GG20834@nuc-i3427.alporthouse.com>

> > > Looks like an incorrect call to drm_encoder_cleanup() from the error
> > > path. If we hit the error path we have never called drm_encoder_init.
> > > Please try:
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
> > > index 47bdf9dad0d3..b9e5a63a7c9e 100644
> > > --- a/drivers/gpu/drm/i915/intel_dvo.c
> > > +++ b/drivers/gpu/drm/i915/intel_dvo.c
> > > @@ -554,7 +554,6 @@ void intel_dvo_init(struct drm_device *dev)
> > >  		return;
> > >  	}
> > >  
> > > -	drm_encoder_cleanup(&intel_encoder->base);
> > >  	kfree(intel_dvo);
> > >  	kfree(intel_connector);
> > >  }
> > 
> > It works - the BUG is gone.
> > 
> > Now I get just 
> > [drm:__intel_set_cpu_fifo_underrun_reporting [i915]] *ERROR* pipe A underrun
> 
> Other than the annoying underrun, is everything else as expected? i.e.
> no connected outputs? Have we lost dvo detection?

Yes, as expected - there is no monitor connected.

-- 
Meelis Roos (mroos@linux.ee)

      reply	other threads:[~2016-08-23 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  9:58 Meelis Roos
2016-08-23  9:11 ` Chris Wilson
2016-08-23 11:35   ` Meelis Roos
2016-08-23 10:10     ` Chris Wilson
2016-08-23 11:46       ` Meelis Roos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.20.1608231445550.17020@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®