From: Jiri Kosina <jkosina@suse.cz>
To: "André Goddard Rosa" <andre.goddard@gmail.com>
Cc: linux list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/16] trivial: fix assorted "through" typos
Date: Mon, 2 Nov 2009 17:00:48 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.00.0911021658110.4203@wotan.suse.de> (raw)
In-Reply-To: <b8bf37780910310240u4aecdf89hb938df7952b572e@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 896 bytes --]
On Sat, 31 Oct 2009, André Goddard Rosa wrote:
> diff --git a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> index f7b9cdc..b52c1f8 100644
> --- a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> +++ b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> @@ -38,7 +38,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
>
> #ifdef CONFIG_BFIN_EXTMEM_DCACHEABLE
> d_cache = CPLB_L1_CHBL;
> -#ifdef CONFIG_BFIN_EXTMEM_WRITETROUGH
> +#ifdef CONFIG_BFIN_EXTMEM_WRITETHROUGH
As this one is fixing a *real* bug, please separate it out from the other
changes which basically just fix typos in comments.
On the other hand, please merge all the other changes together into one
larger patch. We don't want gazillions of commits because you have found
gazillions of words typed wrongly in comments.
Thanks for taking care,
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2009-11-02 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:40 André Goddard Rosa
2009-10-31 10:17 ` Nigel Cunningham
2009-10-31 10:22 ` André Goddard Rosa
2009-10-31 12:11 ` Tilman Schmidt
2009-11-01 17:52 ` Randy Dunlap
2009-11-01 21:13 ` Thiago Farina
2009-11-02 10:40 ` ARRAY_SIZE (was: [PATCH 03/16] trivial: fix assorted "through" typos) Tilman Schmidt
2009-11-02 10:09 ` Kernel cleanup Wiki " Tilman Schmidt
2009-11-02 9:18 ` [PATCH 03/16] trivial: fix assorted "through" typos Ingo Molnar
2009-11-02 16:00 ` Jiri Kosina [this message]
2009-11-02 16:16 ` André Goddard Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0911021658110.4203@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=andre.goddard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®