Re: [PATCH 03/16] trivial: fix assorted "through" typos

["André Goddard Rosa" <andre.goddard@gmail.com>]

On Sat, Oct 31, 2009 at 8:17 AM, Nigel Cunningham
<ncunningham@crca.org.au> wrote:
> I've only looked at this one, but something caught my eye...
>
> André Goddard Rosa wrote:
>> diff --git a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> index f7b9cdc..b52c1f8 100644
>> --- a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> +++ b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> @@ -38,7 +38,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
>>
>>  #ifdef CONFIG_BFIN_EXTMEM_DCACHEABLE
>>       d_cache = CPLB_L1_CHBL;
>> -#ifdef CONFIG_BFIN_EXTMEM_WRITETROUGH
>> +#ifdef CONFIG_BFIN_EXTMEM_WRITETHROUGH
>>       d_cache |= CPLB_L1_AOW | CPLB_WT;
>>  #endif
>>  #endif
>
> "Surely that can't be the only time?", I thought. But it is - all of the
> other #ifdefs are spelled correctly, so you're probably fixing a
> hard-to-find bug here! Good catch!

Good, that's why I made it a separate patch.

> Makes me wonder if anyone's written a tool to find things like this -
> #ifdefs that will never be defined...

Yeah, I thought the same thing; surely it would be nice...
Probably it's not only the one case, I suppose.

With regards,
André