From: Jiri Kosina <jikos@kernel.org>
To: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jessica Yu <jeyu@redhat.com>, Miroslav Benes <mbenes@suse.cz>
Subject: Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)
Date: Sat, 11 Feb 2017 08:54:59 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1702110852560.24579@cbobk.fhfr.pm> (raw)
In-Reply-To: <99aec04ff3cedcf82af22ab147e77225@nuclearcat.com>
On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote:
> I noticed that sample of livepatch is not working in 4.9.9, because in
> include,
> linux/livepatch.h
> it is:
> #if IS_ENABLED(CONFIG_LIVEPATCH)
>
> while config option is:
> CONFIG_HAVE_LIVEPATCH=y
>
> After editing livepatch.h sample module compiles fine
>
> Probably that's just a typo?
There are two config variables. CONFIG_HAVE_LIVEPATCH is set by those
architectures for which livepatching implementation exists.
CONFIG_LIVEPATCH is the actual config option turning the support in kernel
on/off.
What you are seeing is that if you have kernel configuration that has
livepatching (CONFIG_LIVEPATCH) turned off, the sample module doesn't
compile for it either. I'd say it's not unexpected behavior.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-02-11 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 5:08 Denys Fedoryshchenko
2017-02-11 7:54 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1702110852560.24579@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=jeyu@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=nuclearcat@nuclearcat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®