From: Jiri Kosina <jikos@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: Use pr_<level> and remove unnecessary OOM messages
Date: Mon, 6 Mar 2017 14:40:58 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1703061440490.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <17564e41463d71d65783b11cb0b337363f90eecc.1488418441.git.joe@perches.com>
On Wed, 1 Mar 2017, Joe Perches wrote:
> Use a more common logging style and remove the unnecessary
> OOM messages as there is default dump_stack when OOM.
>
> Miscellanea:
>
> o Hoist an assignment in an if
> o Realign arguments
> o Realign a deeply indented if descendent above a printk
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to for-4.12/upstream. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-03-06 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 1:35 Joe Perches
2017-03-06 9:50 ` Benjamin Tissoires
2017-03-06 13:40 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1703061440490.31814@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®