From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Herrmann <dh.herrmann@googlemail.com>,
Oliver Neukum <oneukum@suse.de>,
Jason Gerecke <killertofu@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] HID: remove initial reading of reports at connect
Date: Tue, 21 Mar 2017 15:00:32 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1703211500160.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <20170308141114.9200-1-benjamin.tissoires@redhat.com>
On Wed, 8 Mar 2017, Benjamin Tissoires wrote:
> It looks like a bunch of devices do not like to be polled for their
> reports at init time. When you look into the details, it seems that for
> those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver
> fails to retrieve part of the features/inputs while others (more
> generic) work.
>
> IMO, it should be acceptable to remove the need for the quirk in the
> general case. On the small amount of cases where we actually need to
> read the current values, the driver in charge (hid-mt or wacom) already
> retrieves the features manually.
Applied to for-4.12/nuke-no-init-reports-quirk. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-03-21 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 14:11 Benjamin Tissoires
2017-03-21 14:00 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1703211500160.31814@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dh.herrmann@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®