From: Jiri Kosina <jikos@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>, Jessica Yu <jeyu@redhat.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches
Date: Tue, 11 Apr 2017 20:55:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1704112054580.28004@cbobk.fhfr.pm> (raw)
In-Reply-To: <1491908868-27766-1-git-send-email-pmladek@suse.com>
On Tue, 11 Apr 2017, Petr Mladek wrote:
> klp_init_transition() does not set func->transition for immediate patches.
> Then klp_ftrace_handler() could use the new code immediately. As a result,
> it is not safe to put the livepatch module in klp_cancel_transition().
>
> This patch reverts most of the last minute changes klp_cancel_transition().
> It keeps the warning about a misuse because it still makes sense.
>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> ---
> Hi,
>
> I am afraid that Mirek was not right in the mail
> https://lkml.kernel.org/r/alpine.LSU.2.20.1702161504020.16310@pobox.suse.cz
> IMHO, it is not safe to put the module when the immediate
> patch cannot be applied.
That's a very good catch indeed, thanks. Applied.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-04-11 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 11:07 Petr Mladek
2017-04-11 11:31 ` Miroslav Benes
2017-04-11 15:10 ` Josh Poimboeuf
2017-04-11 18:55 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1704112054580.28004@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=jeyu@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®