* [PATCH 1/2] init/main: Fix double "the" in comment
@ 2017-03-23 11:30 Viresh Kumar
2017-03-23 11:30 ` [PATCH 2/2] init/main: properly align the multi-line comment Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Viresh Kumar @ 2017-03-23 11:30 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linaro-kernel, Vincent Guittot, Viresh Kumar, linux-kernel
s/the\ the/the
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index f9c9d9948203..717b2ab803e5 100644
--- a/init/main.c
+++ b/init/main.c
@@ -495,7 +495,7 @@ asmlinkage __visible void __init start_kernel(void)
debug_objects_early_init();
/*
- * Set up the the initial canary ASAP:
+ * Set up the initial canary ASAP:
*/
boot_init_stack_canary();
--
2.12.0.432.g71c3a4f4ba37
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] init/main: properly align the multi-line comment
2017-03-23 11:30 [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
@ 2017-03-23 11:30 ` Viresh Kumar
2017-04-17 5:51 ` [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
2017-04-24 10:42 ` Viresh Kumar
2 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2017-03-23 11:30 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linaro-kernel, Vincent Guittot, Viresh Kumar, linux-kernel
Add a tab before it to follow standard practices. Also add the missing
full stop '.'.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
init/main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/init/main.c b/init/main.c
index 717b2ab803e5..7bb8e845a8a1 100644
--- a/init/main.c
+++ b/init/main.c
@@ -504,10 +504,10 @@ asmlinkage __visible void __init start_kernel(void)
local_irq_disable();
early_boot_irqs_disabled = true;
-/*
- * Interrupts are still disabled. Do necessary setups, then
- * enable them
- */
+ /*
+ * Interrupts are still disabled. Do necessary setups, then
+ * enable them.
+ */
boot_cpu_init();
page_address_init();
pr_notice("%s", linux_banner);
--
2.12.0.432.g71c3a4f4ba37
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] init/main: Fix double "the" in comment
2017-03-23 11:30 [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
2017-03-23 11:30 ` [PATCH 2/2] init/main: properly align the multi-line comment Viresh Kumar
@ 2017-04-17 5:51 ` Viresh Kumar
2017-04-24 10:42 ` Viresh Kumar
2 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2017-04-17 5:51 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linaro-kernel, Vincent Guittot, linux-kernel
On 23-03-17, 17:00, Viresh Kumar wrote:
> s/the\ the/the
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index f9c9d9948203..717b2ab803e5 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -495,7 +495,7 @@ asmlinkage __visible void __init start_kernel(void)
> debug_objects_early_init();
>
> /*
> - * Set up the the initial canary ASAP:
> + * Set up the initial canary ASAP:
> */
> boot_init_stack_canary();
>
Ping.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] init/main: Fix double "the" in comment
2017-03-23 11:30 [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
2017-03-23 11:30 ` [PATCH 2/2] init/main: properly align the multi-line comment Viresh Kumar
2017-04-17 5:51 ` [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
@ 2017-04-24 10:42 ` Viresh Kumar
2017-04-24 11:14 ` Jiri Kosina
2 siblings, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2017-04-24 10:42 UTC (permalink / raw)
To: akpm; +Cc: Jiri Kosina, linaro-kernel, Vincent Guittot, linux-kernel
On 23-03-17, 17:00, Viresh Kumar wrote:
> s/the\ the/the
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index f9c9d9948203..717b2ab803e5 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -495,7 +495,7 @@ asmlinkage __visible void __init start_kernel(void)
> debug_objects_early_init();
>
> /*
> - * Set up the the initial canary ASAP:
> + * Set up the initial canary ASAP:
> */
> boot_init_stack_canary();
@Andrew: Sorry for bothering you. I wanted to take these patches via the trivial
tree, but no response yet (over a month). Will it be possible to take these
via your tree ?
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] init/main: Fix double "the" in comment
2017-04-24 10:42 ` Viresh Kumar
@ 2017-04-24 11:14 ` Jiri Kosina
2017-04-24 11:16 ` Viresh Kumar
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2017-04-24 11:14 UTC (permalink / raw)
To: Viresh Kumar; +Cc: akpm, linaro-kernel, Vincent Guittot, linux-kernel
On Mon, 24 Apr 2017, Viresh Kumar wrote:
> > ---
> > init/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/init/main.c b/init/main.c
> > index f9c9d9948203..717b2ab803e5 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -495,7 +495,7 @@ asmlinkage __visible void __init start_kernel(void)
> > debug_objects_early_init();
> >
> > /*
> > - * Set up the the initial canary ASAP:
> > + * Set up the initial canary ASAP:
> > */
> > boot_init_stack_canary();
>
> @Andrew: Sorry for bothering you. I wanted to take these patches via the trivial
> tree, but no response yet (over a month). Will it be possible to take these
> via your tree ?
For some reason your previous attemtps were marked as spam. I've now
picked it up.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] init/main: Fix double "the" in comment
2017-04-24 11:14 ` Jiri Kosina
@ 2017-04-24 11:16 ` Viresh Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2017-04-24 11:16 UTC (permalink / raw)
To: Jiri Kosina; +Cc: akpm, linaro-kernel, Vincent Guittot, linux-kernel
On 24-04-17, 13:14, Jiri Kosina wrote:
> On Mon, 24 Apr 2017, Viresh Kumar wrote:
>
> > > ---
> > > init/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/init/main.c b/init/main.c
> > > index f9c9d9948203..717b2ab803e5 100644
> > > --- a/init/main.c
> > > +++ b/init/main.c
> > > @@ -495,7 +495,7 @@ asmlinkage __visible void __init start_kernel(void)
> > > debug_objects_early_init();
> > >
> > > /*
> > > - * Set up the the initial canary ASAP:
> > > + * Set up the initial canary ASAP:
> > > */
> > > boot_init_stack_canary();
> >
> > @Andrew: Sorry for bothering you. I wanted to take these patches via the trivial
> > tree, but no response yet (over a month). Will it be possible to take these
> > via your tree ?
>
> For some reason your previous attemtps were marked as spam. I've now
> picked it up.
Thanks a lot Jiri. I have been in the shit-lists in the pasts, but the spam list
is something new :)
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-24 11:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 11:30 [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
2017-03-23 11:30 ` [PATCH 2/2] init/main: properly align the multi-line comment Viresh Kumar
2017-04-17 5:51 ` [PATCH 1/2] init/main: Fix double "the" in comment Viresh Kumar
2017-04-24 10:42 ` Viresh Kumar
2017-04-24 11:14 ` Jiri Kosina
2017-04-24 11:16 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®