mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Julien Thierry <jthierry@redhat.com>
Cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com,
	peterz@infradead.org, mhelsley@vmware.com
Subject: Re: [PATCH v2 0/4] Remove dependency of check subcmd upon orc
Date: Tue, 9 Jun 2020 11:44:11 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.21.2006091143470.13900@pobox.suse.cz> (raw)
In-Reply-To: <20200608071203.4055-1-jthierry@redhat.com>

On Mon, 8 Jun 2020, Julien Thierry wrote:

> Hi,
> 
> Matt Helsley's change[1] provided a base framework to opt-in/out
> objtool subcommands at compile time. This makes it easier for
> architectures to port objtool, one subcommand at a time.
> 
> Orc generation relies on the check operation implementation. However,
> the way this is done causes the check implementation to depend on the
> implementation of orc generation functions to call if orc generation is
> requested. This means that in order to implement check subcmd, orc
> subcmd also need to be implemented.
> 
> These patches aim at removing that dependency, having orc subcmd
> being built on top of the check subcmd.
> 
> Changes since v1 [2]:
> - Remove redundant check in create_orc pointed out by Miroslav
> 
> [1] https://www.spinics.net/lists/kernel/msg3510844.html
> [2] https://lkml.org/lkml/2020/6/4/675

Reviewed-by: Miroslav Benes <mbenes@suse.cz>

M

      parent reply	other threads:[~2020-06-09  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08  7:11 Julien Thierry
2020-06-08  7:12 ` [PATCH v2 1/4] objtool: Move object file loading out of check Julien Thierry
2020-06-08 18:49   ` Matt Helsley
2020-06-08  7:12 ` [PATCH v2 2/4] objtool: Move orc outside " Julien Thierry
2020-06-08 18:50   ` Matt Helsley
2020-06-08  7:12 ` [PATCH v2 3/4] objtool: orc: Skip setting orc_entry for non-text sections Julien Thierry
2020-06-08  7:12 ` [PATCH v2 4/4] objtool: orc_gen: Move orc_entry out of instruction structure Julien Thierry
2020-06-09  9:44 ` Miroslav Benes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.2006091143470.13900@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=jthierry@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhelsley@vmware.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®