From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: David Howells <dhowells@redhat.com>
Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4]
Date: Mon, 11 Apr 2016 15:21:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.OSX.2.20.1604111508020.2143@mjmartin-mac01.local> (raw)
In-Reply-To: <20160407085811.29311.8948.stgit@warthog.procyon.org.uk>
On Thu, 7 Apr 2016, David Howells wrote:
> diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
> index b9a5487cd82d..0dccb6fe7634 100644
> --- a/crypto/asymmetric_keys/pkcs7_trust.c
> +++ b/crypto/asymmetric_keys/pkcs7_trust.c
> @@ -170,8 +162,7 @@ verified:
> * May also return -ENOMEM.
> */
> int pkcs7_validate_trust(struct pkcs7_message *pkcs7,
> - struct key *trust_keyring,
> - bool *_trusted)
This doesn't build after the keys-trust branch was rebased on v4.6-rc2. A
reference to _trusted was added in commit e5435891 ("PKCS#7:
pkcs7_validate_trust(): initialize the _trusted output argument"), right
after the local declarations.
> + struct key *trust_keyring)
> {
> struct pkcs7_signed_info *sinfo;
> struct x509_certificate *p;
Regards,
--
Mat Martineau
Intel OTC
next prev parent reply other threads:[~2016-04-11 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 8:57 [RFC PATCH 00/12] KEYS: Restrict additions to 'trusted' keyrings " David Howells
2016-04-07 8:58 ` [RFC PATCH 01/12] KEYS: Generalise system_verify_data() to provide access to internal content " David Howells
2016-04-07 8:58 ` [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring " David Howells
2016-04-11 22:21 ` Mat Martineau [this message]
2016-04-11 23:49 ` David Howells
2016-04-07 8:58 ` [RFC PATCH 03/12] KEYS: Add a facility to restrict new links into a " David Howells
2016-04-07 8:58 ` [RFC PATCH 04/12] KEYS: Move x509_request_asymmetric_key() to asymmetric_type.c " David Howells
2016-04-07 8:58 ` [RFC PATCH 05/12] KEYS: Generalise x509_request_asymmetric_key() " David Howells
2016-04-07 8:58 ` [RFC PATCH 06/12] X.509: Use verify_signature() if we have a struct key * to use " David Howells
2016-04-07 8:58 ` [RFC PATCH 07/12] X.509: Move the trust validation code out to its own file " David Howells
2016-04-07 8:58 ` [RFC PATCH 08/12] KEYS: Make the system trusted keyring depend on the asymmetric key type " David Howells
2016-04-07 8:59 ` [RFC PATCH 09/12] KEYS: Move the point of trust determination to __key_link() " David Howells
2016-04-07 8:59 ` [RFC PATCH 10/12] KEYS: Remove KEY_FLAG_TRUSTED and KEY_ALLOC_TRUSTED " David Howells
2016-04-07 8:59 ` [RFC PATCH 11/12] certs: Add a secondary system keyring that can be added to dynamically " David Howells
2016-04-07 8:59 ` [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok " David Howells
2016-04-12 14:50 ` Mimi Zohar
2016-04-12 17:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.20.1604111508020.2143@mjmartin-mac01.local \
--to=mathew.j.martineau@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®