From: mroos@linux.ee
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
JBottomley@parallels.com
Subject: Re: [PATCH v2 0/4] fix / cleanup async scsi scanning
Date: Thu, 31 May 2012 12:05:15 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1205311203530.29083@math.ut.ee> (raw)
In-Reply-To: <20120530182016.23574.11056.stgit@dwillia2-linux.jf.intel.com>
> Commit a7a20d10 "[SCSI] sd: limit the scope of the async probe domain"
> introduces a boot regression by moving sd probe work off of the global
> async queue. Using a local async domain hides the probe work from being
> synchronized by wait_for_device_probe()->async_synchronize_full().
>
> Fix this by teaching async_synchronize_full() to flush all async work
> regardless of domain, and take the opportunity to convert scsi scanning
> to async_schedule(). This enables wait_for_device_probe() to flush scsi
> scanning work.
>
> Changes since v1: http://marc.info/?l=linux-scsi&m=133793153025832&w=2
>
> 1/ Tested to fix the boot hang that Meelis reported with v1. Reworked
> async_synchronize_full() to walk through all the active domains,
> otherwise we spin on !list_empty(async_domains) and prevent the async
> context from running.
>
> 2/ Added the ability for domains to opt-out of global syncing as
> requested by Arjan, but also needed for domains that don't want to worry
> about list corruption when the domain goes out of scope (stack-allocated
> domains).
Tested successfully on my Netra X1 where the original problem happened,
on top of 3.4.0-08215-g1e2aec8. Thank you!
--
Meelis Roos (mroos@linux.ee)
prev parent reply other threads:[~2012-05-31 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 18:21 Dan Williams
2012-05-30 18:21 ` [PATCH v2 1/4] async: introduce 'async_domain' type Dan Williams
2012-05-30 18:21 ` [PATCH v2 2/4] async: make async_synchronize_full() flush all work regardless of domain Dan Williams
2012-05-30 18:21 ` [PATCH v2 3/4] scsi: queue async scan work to an async_schedule domain Dan Williams
2012-05-30 18:21 ` [PATCH v2 4/4] scsi: cleanup usages of scsi_complete_async_scans Dan Williams
2012-05-30 21:34 ` Rafael J. Wysocki
2012-05-30 21:37 ` Rafael J. Wysocki
2012-05-30 21:41 ` Rafael J. Wysocki
2012-05-30 21:49 ` Dan Williams
2012-05-30 18:22 ` [PATCH v2 0/4] fix / cleanup async scsi scanning Borislav Petkov
2012-05-30 18:29 ` Dan Williams
2012-05-30 22:33 ` walt
2012-05-31 13:37 ` Borislav Petkov
2012-05-31 9:05 ` mroos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1205311203530.29083@math.ut.ee \
--to=mroos@linux.ee \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®