Re: [PATCH v2] xtensa: atomics: drop kernel-doc comments

[Mark Rutland <mark.rutland@arm.com>]

On Mon, Jul 20, 2026 at 07:00:23PM -0700, Randy Dunlap wrote:
> The arch-specific kernel-doc comments were supposed to be deleted in
> commit: ef558b4b7bbb
> ("locking/atomic: treewide: delete arch_atomic_*() kerneldoc"), [1]
> but these were missed, so delete them now.
> 
> Warning: ./arch/xtensa/include/asm/atomic.h:45 expecting prototype for
>   atomic_read(). Prototype was for arch_atomic_read() instead
> Warning: ./arch/xtensa/include/asm/atomic.h:54 expecting prototype for
>   atomic_set(). Prototype was for arch_atomic_set() instead
> 
> Link [1]:
> https://lore.kernel.org/all/al3q54jxOKZujYue@J2N7QTR9R3.cambridge.arm.com/
> Fixes: ef558b4b7bbb ("locking/atomic: treewide: delete arch_atomic_*() kerneldoc")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks for this!

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
> v2: drop the arch-specific kernel-doc comments (Mark R.)
> 
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Boqun Feng <boqun@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Gary Guo <gary@garyguo.net>
> 
>  arch/xtensa/include/asm/atomic.h |   13 -------------
>  1 file changed, 13 deletions(-)
> 
> --- linux-next-20260720.orig/arch/xtensa/include/asm/atomic.h
> +++ linux-next-20260720/arch/xtensa/include/asm/atomic.h
> @@ -37,21 +37,8 @@
>   * where no register reference will cause an overflow.
>   */
>  
> -/**
> - * atomic_read - read atomic variable
> - * @v: pointer of type atomic_t
> - *
> - * Atomically reads the value of @v.
> - */
>  #define arch_atomic_read(v)		READ_ONCE((v)->counter)
>  
> -/**
> - * atomic_set - set atomic variable
> - * @v: pointer of type atomic_t
> - * @i: required value
> - *
> - * Atomically sets the value of @v to @i.
> - */
>  #define arch_atomic_set(v,i)		WRITE_ONCE((v)->counter, (i))
>  
>  #if XCHAL_HAVE_EXCLUSIVE