From: Dan Carpenter <error27@gmail.com>
To: ColtenOuO <jun930436@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hansg@kernel.org>,
Michael Straube <straube.linux@gmail.com>,
Nikolay Kulikov <nikolayof23@gmail.com>,
Andrei Khomenkov <khomenkov@mailbox.org>,
Jennifer Guo <guojy.bj@gmail.com>, Minu Jin <s9430939@naver.com>,
Khasar Munkh-Erdene <02khasar@gmail.com>,
Mohammed Rizwan Kaniyate <mrizwank004@gmail.com>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary else after break/return
Date: Thu, 23 Jul 2026 11:29:42 +0300 [thread overview]
Message-ID: <amHQ9nTvkU6cAg_N@stanley.mountain> (raw)
In-Reply-To: <20260721160236.80963-1-jun930436@gmail.com>
On Tue, Jul 21, 2026 at 04:02:32PM +0000, ColtenOuO wrote:
> checkpatch.pl flags an else clause following a branch that already
> returns, in enqueue_reorder_recvframe(). Restructure the if/else-if/else
> chain into sequential checks to remove the redundant else, with no
> change in behavior.
>
> Signed-off-by: ColtenOuO <jun930436@gmail.com>
That's not the name you use to sign legal documents.
But really, the original code is fine, just ignore tools when they are
wrong.
regards,
dan carpenter
prev parent reply other threads:[~2026-07-23 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 16:02 ColtenOuO
2026-07-23 8:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amHQ9nTvkU6cAg_N@stanley.mountain \
--to=error27@gmail.com \
--cc=02khasar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=hansg@kernel.org \
--cc=jun930436@gmail.com \
--cc=khomenkov@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mrizwank004@gmail.com \
--cc=nikolayof23@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®