From: Frank Li <Frank.li@oss.nxp.com>
To: Koichiro Den <den@valinux.co.jp>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>, "Frank Li" <Frank.Li@kernel.org>,
"Gustavo Pimentel" <Gustavo.Pimentel@synopsys.com>,
"Kees Cook" <kees@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Christoph Hellwig" <hch@lst.de>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Niklas Cassel" <cassel@kernel.org>,
"Devendra K Verma" <devendra.verma@amd.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization
Date: Mon, 27 Jul 2026 16:18:01 -0400 [thread overview]
Message-ID: <ame8-QU4siDSPzaS@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260727170323.2321369-11-den@valinux.co.jp>
On Tue, Jul 28, 2026 at 02:03:09AM +0900, Koichiro Den wrote:
> Both eDMA and HDMA perform the same remote LL read-back immediately
> before writing the doorbell register.
>
> A later patch serializes each LL doorbell write against IRQ event
> capture with a raw spinlock. Keeping the read-back in the provider
> callback would hold that lock across a remote read. Move the common
> read-back into a core kick helper, where it can run before the
> serialized section, and leave dw_edma_core_ch_maybe_doorbell() to decide
> whether a kick is needed.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
> Changes in v3:
> - New prep patch split from "Centralize LL doorbell decisions" to keep
> that policy change focused and the remote LL read-back outside the
> event lock added later. (Sashiko)
>
> drivers/dma/dw-edma/dw-edma-core.c | 20 +++++++++++++++++++-
> drivers/dma/dw-edma/dw-edma-v0-core.c | 16 ----------------
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 16 ----------------
> 3 files changed, 19 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index bb57f2d39d1c..e3d0559206d8 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -13,6 +13,7 @@
> #include <linux/dmaengine.h>
> #include <linux/err.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/irq.h>
> #include <linux/dma/edma.h>
> #include <linux/dma-mapping.h>
> @@ -254,6 +255,23 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
> chan->status = EDMA_ST_IDLE;
> }
>
> +static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
> +{
> + /*
> + * Remote controller registers and LL memory may be reached through
> + * different paths. Complete posted LL writes before the doorbell.
> + */
> + if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
> + readl(chan->ll_region.vaddr.io);
> +}
> +
> +/* Must be called with vc.lock held for an LL channel. */
> +static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
> +{
> + dw_edma_core_ll_sync(chan);
> + dw_edma_core_ch_doorbell(chan);
> +}
> +
Can you move
if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
readl(chan->ll_region.vaddr.io);
into funciton dw_edma_core_ch_doorbell().
Frank
> /* Must be called with vc.lock held. */
> static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
> {
> @@ -261,7 +279,7 @@ static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
> chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan))
> return;
>
> - dw_edma_core_ch_doorbell(chan);
> + dw_edma_core_ch_kick(chan);
> }
>
> static void dw_edma_device_caps(struct dma_chan *dchan,
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> index d883ca446f5a..b3098eb83442 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -480,20 +480,6 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_chan *chan)
> upper_32_bits(chan->ll_region.paddr));
> }
>
> -static void dw_edma_v0_sync_ll_data(struct dw_edma_chan *chan)
> -{
> - /*
> - * In case of remote eDMA engine setup, the DW PCIe RP/EP internal
> - * configuration registers and application memory are normally accessed
> - * over different buses. Ensure LL-data reaches the memory before the
> - * doorbell register is toggled by issuing the dummy-read from the remote
> - * LL memory in a hope that the MRd TLP will return only after the
> - * last MWr TLP is completed
> - */
> - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
> - readl(chan->ll_region.vaddr.io);
> -}
> -
> static void dw_edma_v0_core_ch_config(struct dw_edma_chan *chan)
> {
> struct dw_edma *dw = chan->dw;
> @@ -624,8 +610,6 @@ static void dw_edma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
> {
> struct dw_edma *dw = chan->dw;
>
> - dw_edma_v0_sync_ll_data(chan);
> -
> /* Doorbell */
> SET_RW_32(dw, chan->dir, doorbell,
> FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index afc2f24fecd3..64a07fbc5be3 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -282,20 +282,6 @@ static void dw_hdma_v0_core_ch_enable(struct dw_edma_chan *chan)
> HDMA_V0_CONSUMER_CYCLE_STAT | HDMA_V0_CONSUMER_CYCLE_BIT);
> }
>
> -static void dw_hdma_v0_sync_ll_data(struct dw_edma_chan *chan)
> -{
> - /*
> - * In case of remote HDMA engine setup, the DW PCIe RP/EP internal
> - * configuration registers and application memory are normally accessed
> - * over different buses. Ensure LL-data reaches the memory before the
> - * doorbell register is toggled by issuing the dummy-read from the remote
> - * LL memory in a hope that the MRd TLP will return only after the
> - * last MWr TLP is completed
> - */
> - if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
> - readl(chan->ll_region.vaddr.io);
> -}
> -
> static void dw_hdma_v0_core_non_ll_start(struct dw_edma_chan *chan,
> struct dw_edma_burst *child)
> {
> @@ -393,8 +379,6 @@ static void dw_hdma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
> {
> struct dw_edma *dw = chan->dw;
>
> - dw_hdma_v0_sync_ll_data(chan);
> -
> /* Doorbell */
> SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START);
> }
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-07-27 20:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
2026-07-27 17:03 ` [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index Koichiro Den
2026-07-27 17:03 ` [PATCH v3 02/24] dmaengine: dw-edma: Add dw_edma_core_ll_clear() to clear LL control-word Koichiro Den
2026-07-27 17:03 ` [PATCH v3 03/24] dmaengine: dw-edma: Factor out linked-list transfer start Koichiro Den
2026-07-27 17:03 ` [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer Koichiro Den
2026-07-27 19:09 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 05/24] dmaengine: dw-edma: Move callback result helper before LL helpers Koichiro Den
2026-07-27 17:03 ` [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
2026-07-27 19:11 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions Koichiro Den
2026-07-27 17:03 ` [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
2026-07-27 19:47 ` Frank Li
2026-07-28 6:03 ` Koichiro Den
2026-07-27 20:09 ` Frank Li
2026-07-28 6:02 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events Koichiro Den
2026-07-27 20:12 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization Koichiro Den
2026-07-27 20:18 ` Frank Li [this message]
2026-07-28 5:38 ` Koichiro Den
2026-07-28 15:43 ` Frank Li
2026-07-28 17:34 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 11/24] dmaengine: dw-edma: Serialize LL event capture with channel kicks Koichiro Den
2026-07-27 20:35 ` Frank Li
2026-07-28 6:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending Koichiro Den
2026-07-27 17:03 ` [PATCH v3 13/24] dmaengine: dw-edma: Reclaim issued descriptors from IRQ-paired LL progress Koichiro Den
2026-07-27 17:03 ` [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy Koichiro Den
2026-07-27 17:03 ` [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart Koichiro Den
2026-07-27 17:03 ` [PATCH v3 16/24] dmaengine: dw-edma: Use HDMA watermarks as progress events Koichiro Den
2026-07-27 17:03 ` [PATCH v3 17/24] dmaengine: dw-edma: Recover stopped channels from tx_status() Koichiro Den
2026-07-27 17:03 ` [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync Koichiro Den
2026-07-27 17:03 ` [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE Koichiro Den
2026-07-27 17:03 ` [PATCH v3 20/24] dmaengine: dw-edma: Dynamically append requests while running Koichiro Den
2026-07-27 17:03 ` [PATCH v3 21/24] dmaengine: dw-edma: Add engine reset and enable operations Koichiro Den
2026-07-27 17:03 ` [PATCH v3 22/24] dmaengine: dw-edma: Add engine recovery infrastructure Koichiro Den
2026-07-27 17:03 ` [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine Koichiro Den
2026-07-27 17:03 ` [PATCH v3 24/24] dmaengine: dw-edma: Add trace support Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ame8-QU4siDSPzaS@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=cassel@kernel.org \
--cc=den@valinux.co.jp \
--cc=devendra.verma@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=hch@lst.de \
--cc=kees@kernel.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®