From: Thorsten Blum <thorsten.blum@linux.dev>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Ard Biesheuvel <ardb@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] x86/boot/compressed: Enable -Wunused and remove unused variables
Date: Tue, 28 Jul 2026 07:49:23 +0200 [thread overview]
Message-ID: <amhC4yES_arrVaqP@linux.dev> (raw)
In-Reply-To: <20260624120300.590233-6-thorsten.blum@linux.dev>
On Wed, Jun 24, 2026 at 02:02:54PM +0200, Thorsten Blum wrote:
> This series marks potentially unused variables and functions as
> __maybe_unused and removes truly unused ones. Patch 4 enables -Wunused,
> matching the W=0 kernel defaults. With WERROR=y, the warnings failed as
> follows:
>
> arch/x86/boot/compressed/acpi.c:25:1: error: ‘__efi_get_rsdp_addr’ defined but not used
> arch/x86/boot/compressed/acpi.c:29:6: error: unused variable 'ret'
> arch/x86/boot/compressed/acpi.c:57:15: error: unused variable 'nr_tables'
> arch/x86/boot/compressed/efi.c:64:16: error: unused variable 'et'
> arch/x86/boot/compressed/efi.c:136:6: error: unused variable 'ret'
> arch/x86/boot/compressed/kaslr.c:600:13: error: unused variable ‘i’
>
> Patch 2 also drops a redundant efi_get_system_table() call and uses the
> existing efi_get_conf_table() error path.
>
> Changes in v2:
> - Fix a kernel test robot issue by marking __efi_get_rsdp_addr() as
> __maybe_unused: https://lore.kernel.org/r/202606240416.cXegPpiJ-lkp@intel.com/
> - v1: https://lore.kernel.org/r/20260621144116.224010-6-thorsten.blum@linux.dev/
>
> Thorsten Blum (4):
> x86/boot/compressed: Remove unused variables in EFI helpers
> x86/boot/compressed: Clean up EFI RSDP lookup in efi_get_rsdp_addr()
> x86/boot/compressed: Mark process_mem_region() index __maybe_unused
> x86/boot/compressed: Enable -Wunused
>
> arch/x86/boot/compressed/Makefile | 3 +++
> arch/x86/boot/compressed/acpi.c | 18 ++++--------------
> arch/x86/boot/compressed/efi.c | 17 +++++------------
> arch/x86/boot/compressed/kaslr.c | 3 ++-
> 4 files changed, 14 insertions(+), 27 deletions(-)
>
>
> base-commit: 840ef6c78e6a2f694b578ecb9063241c992aaa9e
Gentle ping.
Thanks,
Thorsten
prev parent reply other threads:[~2026-07-28 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:02 Thorsten Blum
2026-06-24 12:02 ` [PATCH v2 1/4] x86/boot/compressed: Remove unused variables in EFI helpers Thorsten Blum
2026-06-24 12:02 ` [PATCH v2 2/4] x86/boot/compressed: Clean up EFI RSDP lookup in efi_get_rsdp_addr() Thorsten Blum
2026-06-24 12:02 ` [PATCH v2 3/4] x86/boot/compressed: Mark process_mem_region() index __maybe_unused Thorsten Blum
2026-06-24 12:02 ` [PATCH v2 4/4] x86/boot/compressed: Enable -Wunused Thorsten Blum
2026-07-28 5:49 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amhC4yES_arrVaqP@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®