From: Tycho Andersen <tycho@kernel.org>
To: Alexander Lougovski <alougovs@redhat.com>
Cc: bp@alien8.de, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, thomas.lendacky@amd.com,
vkuznets@redhat.com
Subject: Re: [PATCH] KVM: SVM: make svm_flush_tlb_gva do a full asid flush if NPT enabled
Date: Thu, 30 Jul 2026 10:26:46 -0600 [thread overview]
Message-ID: <amt5YCuJhzpxHMK7@tycho.pizza> (raw)
In-Reply-To: <20260730110248.49444-1-alougovs@redhat.com>
On Thu, Jul 30, 2026 at 01:02:46PM +0200, Alexander Lougovski wrote:
> On Tue, Jul 28, 2026 at 03:34:36PM -0600, Tycho Andersen wrote:
> > my LLM complained about the '% 2800000', looks like it's selecting
> > from 1..2.8M in a 1.6M table, so the updates above 1.6M don't affect
> > any rows.
>
> Hi Tycho,
> ah, true. Your LLM is correct. I've been experimenting with the different sizes of DB to ensure more memory churn (avoid sql reading from the cache) but then settled back to 1.6M.
Ok, makes sense. I found enough hardware yesterday to run ~35 VMs with
a bit of memory pressure, so smaller is better for me.
When you say "200 VM hours", I guess that's an average? Or do you find
they need to run that long to see the fault?
Also, how are you detecting the BSOD? I'm just waiting for ssh to stop
responding and screen capping the VNC, but maybe there's a better way.
>
> Another thing to mention, it looks like 1582 workload version I've shared doesn't work correctly. So I'm attaching an improved version which mitigates problems - the version I shared before, was still generating a noticeable amount of TLB flushes but still wasn't exactly working as it's supposed to. So here is the improved version:
Thanks for this, I'll update. Though based on:
#!/usr/bin/env bpftrace
kprobe:svm_flush_tlb_gva
{
$vcpu = (struct kvm_vcpu *)arg0;
printf("%-14llu %-7d %-16s %-4d 0x%lx\n",
nsecs / 1000000, pid, comm,
$vcpu->vcpu_id,
arg1);
}
I was already getting quite a few of these flushes, so your scripts
are working somewhat :)
> -cpu host,hv-time=on,hv-relaxed=on,hv-vapic=on,hv-spinlocks=0x1fff,hv-vpindex=on,hv-runtime=on,hv-synic=on,hv-reset=on,hv-frequencies=on,hv-tlbflush=on,hv-ipi=on
Thanks for this as well, I only had hv-tlbflush=on, I'll go ahead and
adapt my command line to yours.
Cheers,
Tycho
next prev parent reply other threads:[~2026-07-30 16:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 9:44 Paolo Bonzini
2026-07-24 22:36 ` Sean Christopherson
2026-07-25 13:37 ` Paolo Bonzini
2026-07-24 23:42 ` Yosry Ahmed
2026-07-24 23:50 ` Yosry Ahmed
2026-07-25 13:32 ` Paolo Bonzini
2026-07-25 21:33 ` Yosry Ahmed
2026-07-27 19:23 ` Tycho Andersen
2026-07-27 19:58 ` Yosry Ahmed
2026-07-29 23:41 ` Paolo Bonzini
2026-07-30 0:24 ` Yosry Ahmed
2026-07-28 17:13 ` Alexander Lougovski
2026-07-28 21:34 ` Tycho Andersen
2026-07-30 11:02 ` Alexander Lougovski
2026-07-30 16:26 ` Tycho Andersen [this message]
2026-08-01 14:53 ` Alexander Lougovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amt5YCuJhzpxHMK7@tycho.pizza \
--to=tycho@kernel.org \
--cc=alougovs@redhat.com \
--cc=bp@alien8.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®