From: Paolo Bonzini <pbonzini@redhat.com>
To: Yosry Ahmed <yosry@kernel.org>, Tycho Andersen <tycho@kernel.org>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Borislav Petkov <bp@alien8.de>,
Sean Christopherson <seanjc@google.com>,
Alexander Lougovski <alougovs@redhat.com>
Subject: Re: [PATCH] KVM: SVM: make svm_flush_tlb_gva do a full asid flush if NPT enabled
Date: Thu, 30 Jul 2026 01:41:04 +0200 [thread overview]
Message-ID: <bb63796e-37ad-4c88-a4cb-198bd6da65e3@redhat.com> (raw)
In-Reply-To: <CAO9r8zMopB=YKXs5pkQmPf9uHKE0P0XORcNbc60AWXTusuY3tg@mail.gmail.com>
On 7/27/26 21:58, Yosry Ahmed wrote:
> On Mon, Jul 27, 2026 at 12:23 PM Tycho Andersen <tycho@kernel.org> wrote:
>>
>> Hi all,
>>
>> On Thu, Jul 23, 2026 at 11:44:19AM +0200, Paolo Bonzini wrote:
>>> As to the workload, Alexander threw more or less everything at the same
>>> time at the VM:
>>>
>>> - a full Windows Defender scan every 30 minutes
>>>
>>> - a disk I/O job
>>>
>>> - a loop doing repeated mmap of system files (mostly to hope that
>>> it triggers some consistency check in the Windows memory manager)
>>>
>>> - SQL Express 2022 + StressDB (1.6M rows), with the host doing queries
>>> (75% write/25% read) via sqlcmd
>>
>> Can you share the code for the mmap + disk io + DB content generator?
>>
>> We're looking at this and would like to reproduce.
>
> Not sure if this is relevant, but I see that hyperv_tlb_flush is flaky
> with npt=0 on Turin at the tip of kvm-x86/next (commit 567329869b9c7).
Same on Milan, but ept=0 works.
> It's not likely because the problem fixed by this patch happens
> specifically with npt=1 and not npt=0 AFAICT, but it is a weird
> coincidence :)
And also because this patch uses, in the end, the same flush mechanism
that npt=0 and ept=0 already use. So that bug is probably in npt=0.
That said, I'll do a quick experiment of running hyperv_tlb_flush in a
loop with this patch.
Paolo
> Maybe something is wrong in the Hyper-V code that manifests
> differently with npt=0/1?
next prev parent reply other threads:[~2026-07-29 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 9:44 Paolo Bonzini
2026-07-24 22:36 ` Sean Christopherson
2026-07-25 13:37 ` Paolo Bonzini
2026-07-24 23:42 ` Yosry Ahmed
2026-07-24 23:50 ` Yosry Ahmed
2026-07-25 13:32 ` Paolo Bonzini
2026-07-25 21:33 ` Yosry Ahmed
2026-07-27 19:23 ` Tycho Andersen
2026-07-27 19:58 ` Yosry Ahmed
2026-07-29 23:41 ` Paolo Bonzini [this message]
2026-07-30 0:24 ` Yosry Ahmed
2026-07-28 17:13 ` Alexander Lougovski
2026-07-28 21:34 ` Tycho Andersen
2026-07-30 11:02 ` Alexander Lougovski
2026-07-30 16:26 ` Tycho Andersen
2026-08-01 14:53 ` Alexander Lougovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb63796e-37ad-4c88-a4cb-198bd6da65e3@redhat.com \
--to=pbonzini@redhat.com \
--cc=alougovs@redhat.com \
--cc=bp@alien8.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=tycho@kernel.org \
--cc=vkuznets@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®