From: Matt Fleming <matt@readmodwrite.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [BUG] xfs: sparse inode allocation can trip i != 1 after AGFL growth
Date: Thu, 30 Jul 2026 14:06:19 +0100 [thread overview]
Message-ID: <amtFONut0xhq8qTP@matt-Precision-5490> (raw)
In-Reply-To: <ampLZcB3CAzLPKV5@bfoster>
On Wed, Jul 29, 2026 at 02:50:13PM -0400, Brian Foster wrote:
>
> I want to think about that a little more and need to run more tests, but
> unless something better comes along I'll try to post that soonish. BTW,
> I had to make some tweaks to the reproducer test to make it work on my
> fedora based test vm. Is this something you plan to post for upstream
> inclusion?
>
> Brian
>
> --- 8< ---
>
> diff --git a/tests/xfs/842 b/tests/xfs/842
> index 9e694a56..5455998f 100755
> --- a/tests/xfs/842
> +++ b/tests/xfs/842
> @@ -293,9 +293,9 @@ inspect_unmounted
> read -r free reserved used <<<"$(ag0_reservation_state)"
> reservation=$((reserved - used))
> outside=$((free - reservation))
> -bno_level=$(agf_field 'levels[0]')
> -cnt_level=$(agf_field 'levels[1]')
> -rmap_level=$(agf_field 'levels[2]')
> +bno_level=$(agf_field bnolevel)
> +cnt_level=$(agf_field cntlevel)
> +rmap_level=$(agf_field rmaplevel)
> flcount=$(agf_field flcount)
> bno_recs=$(alloc_root_field bnoroot numrecs)
> cnt_recs=$(alloc_root_field cntroot numrecs)
Thanks for catching this! Yeah I'll submit this upstream.
Thanks,
Matt
prev parent reply other threads:[~2026-07-30 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 13:04 Matt Fleming
2026-07-17 17:55 ` Brian Foster
2026-07-20 10:37 ` Matt Fleming
2026-07-29 18:50 ` Brian Foster
2026-07-30 13:06 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amtFONut0xhq8qTP@matt-Precision-5490 \
--to=matt@readmodwrite.com \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®