From: Bjorn Andersson <andersson@kernel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] firmware: qcom: scm: simplify code by using classes
Date: Thu, 30 Jul 2026 16:04:18 -0500 [thread overview]
Message-ID: <amu8OkjKt4v4t4CN@baldur> (raw)
In-Reply-To: <20260701-qcom-scm-code-shrink-v1-0-02f5ce02c95a@oss.qualcomm.com>
On Wed, Jul 01, 2026 at 03:38:54PM +0200, Bartosz Golaszewski wrote:
> There's a pattern of enabling the clocks and/or setting the bandwith
> limits before performing an SCM call and reverting the above after it's
> node. In all places it's done unconditionally and can be simplified by
> providing appropriate classes. There are also a few places where we can
> use __free() for tzmem pointers.
>
This ended up conflicting with the PAS changes, can you please rebase?
Regards,
Bjorn
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Bartosz Golaszewski (4):
> firmware: qcom: tzmem: guard against IS_ERR() in the cleanup handler
> firmware: qcom: scm: use __free(qcom_tzmem) to simplify cleanup
> firmware: qcom: scm: introduce qcom_scm_clk class for clock management
> firmware: qcom: scm: introduce qcom_scm_bw class for bandwidth management
>
> drivers/firmware/qcom/qcom_scm.c | 184 ++++++++++++-------------------
> include/linux/firmware/qcom/qcom_tzmem.h | 2 +-
> 2 files changed, 73 insertions(+), 113 deletions(-)
> ---
> base-commit: be5c93fa674f0fc3c8f359c2143abce6bbb422e6
> change-id: 20260701-qcom-scm-code-shrink-c9aff845537d
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>
prev parent reply other threads:[~2026-07-30 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:38 Bartosz Golaszewski
2026-07-01 13:38 ` [PATCH 1/4] firmware: qcom: tzmem: guard against IS_ERR() in the cleanup handler Bartosz Golaszewski
2026-07-02 8:10 ` Mukesh Ojha
2026-07-02 9:47 ` Bartosz Golaszewski
2026-07-02 10:24 ` Mukesh Ojha
2026-07-02 10:04 ` Konrad Dybcio
2026-07-02 10:53 ` Konrad Dybcio
2026-07-01 13:38 ` [PATCH 2/4] firmware: qcom: scm: use __free(qcom_tzmem) to simplify cleanup Bartosz Golaszewski
2026-07-02 8:24 ` Mukesh Ojha
2026-07-02 9:54 ` Konrad Dybcio
2026-07-01 13:38 ` [PATCH 3/4] firmware: qcom: scm: introduce qcom_scm_clk class for clock management Bartosz Golaszewski
2026-07-02 8:41 ` Mukesh Ojha
2026-07-02 9:58 ` Konrad Dybcio
2026-07-01 13:38 ` [PATCH 4/4] firmware: qcom: scm: introduce qcom_scm_bw class for bandwidth management Bartosz Golaszewski
2026-07-02 8:38 ` Mukesh Ojha
2026-07-02 9:59 ` Konrad Dybcio
2026-07-30 21:04 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amu8OkjKt4v4t4CN@baldur \
--to=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®