From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] firmware: qcom: scm: introduce qcom_scm_clk class for clock management
Date: Thu, 2 Jul 2026 11:58:26 +0200 [thread overview]
Message-ID: <356df014-62ae-42b1-9745-673db02abcc9@oss.qualcomm.com> (raw)
In-Reply-To: <20260701-qcom-scm-code-shrink-v1-3-02f5ce02c95a@oss.qualcomm.com>
On 7/1/26 3:38 PM, Bartosz Golaszewski wrote:
> Define DEFINE_CLASS(qcom_scm_clk) that calls qcom_scm_clk_enable() on
> construction and automatically calls qcom_scm_clk_disable() at scope exit
> *if* the enable succeeded.
>
> This allows us to convert all call sites to using
> CLASS(qcom_scm_clk, clk)() instead of the manual enable/check/disable
> pattern and to remove the associated goto labels.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-07-02 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:38 [PATCH 0/4] firmware: qcom: scm: simplify code by using classes Bartosz Golaszewski
2026-07-01 13:38 ` [PATCH 1/4] firmware: qcom: tzmem: guard against IS_ERR() in the cleanup handler Bartosz Golaszewski
2026-07-02 8:10 ` Mukesh Ojha
2026-07-02 9:47 ` Bartosz Golaszewski
2026-07-02 10:24 ` Mukesh Ojha
2026-07-02 10:04 ` Konrad Dybcio
2026-07-02 10:53 ` Konrad Dybcio
2026-07-01 13:38 ` [PATCH 2/4] firmware: qcom: scm: use __free(qcom_tzmem) to simplify cleanup Bartosz Golaszewski
2026-07-02 8:24 ` Mukesh Ojha
2026-07-02 9:54 ` Konrad Dybcio
2026-07-01 13:38 ` [PATCH 3/4] firmware: qcom: scm: introduce qcom_scm_clk class for clock management Bartosz Golaszewski
2026-07-02 8:41 ` Mukesh Ojha
2026-07-02 9:58 ` Konrad Dybcio [this message]
2026-07-01 13:38 ` [PATCH 4/4] firmware: qcom: scm: introduce qcom_scm_bw class for bandwidth management Bartosz Golaszewski
2026-07-02 8:38 ` Mukesh Ojha
2026-07-02 9:59 ` Konrad Dybcio
2026-07-30 21:04 ` [PATCH 0/4] firmware: qcom: scm: simplify code by using classes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356df014-62ae-42b1-9745-673db02abcc9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®