mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Ben Horgan <ben.horgan@arm.com>,
	James Morse <james.morse@arm.com>,
	"Dave Martin" <Dave.Martin@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <fustini@kernel.org>,
	Fenghua Yu <fenghuay@nvidia.com>, Chen Yu <yu.c.chen@intel.com>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Newman <peternewman@google.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept
Date: Thu, 6 Aug 2026 10:04:26 -0700	[thread overview]
Message-ID: <anS-mmfKYa9kHgGb@agluck-desk3> (raw)
In-Reply-To: <7a8b6cc8-d194-4af2-9fb9-2438d2dcae01@intel.com>

On Wed, Aug 05, 2026 at 04:57:04PM -0700, Reinette Chatre wrote:
> Hi Ben,
> 
> On 8/5/26 9:59 AM, Ben Horgan wrote:
> > Just given a go at running this on a model with MPAM and I can mount resctrl with this
> > small patch to initialise the emulated_by lists so that list_empty() behaves.
> > 
> > diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c
> > index 21dcbf5764cc..638095649151 100644
> > --- a/drivers/resctrl/mpam_resctrl.c
> > +++ b/drivers/resctrl/mpam_resctrl.c
> > @@ -1018,6 +1018,7 @@ static int mpam_resctrl_control_init(struct mpam_resctrl_res *res)
> >         case RDT_RESOURCE_L3:
> >                 mpam_ctrl->r_ctrl.type = RESCTRL_CTRL_BITMAP;
> >                 mpam_ctrl->r_ctrl.name = RESCTRL_CTRL_NAME_DEF;
> > +               INIT_LIST_HEAD(&mpam_ctrl->r_ctrl.emulated_by);
> >                 INIT_LIST_HEAD_RCU(&mpam_ctrl->r_ctrl.domains);
> >                 __set_bit(RESCTRL_BITMAP_FLAG_SPARSE, mpam_ctrl->r_ctrl.bitmap.flags);
> >                 mpam_ctrl->r_ctrl.bitmap.cbm_len = class->props.cpbm_wd;
> > @@ -1048,6 +1049,7 @@ static int mpam_resctrl_control_init(struct mpam_resctrl_res *res)
> >                 r->ctrl_scope = RESCTRL_L3_CACHE;
> >                 mpam_ctrl->r_ctrl.type = RESCTRL_CTRL_SCALAR;
> >                 mpam_ctrl->r_ctrl.name = RESCTRL_CTRL_NAME_DEF;
> > +               INIT_LIST_HEAD(&mpam_ctrl->r_ctrl.emulated_by);
> >                 INIT_LIST_HEAD_RCU(&mpam_ctrl->r_ctrl.domains);
> > 
> >                 r->bw_throttle_mode = THREAD_THROTTLE_UNDEFINED;
> 
> Thank you for this. Added this and it is now available in branch resctrl/controls_rfc_v2.1

Is same needed for x86? I don't see any initialization of the
"r_ctrl.emulated_by" lists in similar initialization functions.

-Tony

  reply	other threads:[~2026-08-06 17:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  5:26 Reinette Chatre
2026-08-05 16:59 ` Ben Horgan
2026-08-05 23:57   ` Reinette Chatre
2026-08-06 17:04     ` Luck, Tony [this message]
2026-08-06 17:11       ` Reinette Chatre
2026-08-07 14:14         ` Moger, Babu
2026-08-07 15:35           ` Reinette Chatre
2026-08-07 18:33             ` Moger, Babu
2026-08-07 22:53               ` Reinette Chatre
2026-08-10 18:52                 ` Babu Moger
2026-08-11  4:06                   ` Reinette Chatre
2026-08-11 14:59                     ` Babu Moger
2026-08-11 15:30                       ` Reinette Chatre
2026-08-11 16:09                         ` Babu Moger
2026-08-07 15:35           ` Chen, Yu C
2026-08-07 17:57             ` Moger, Babu
2026-08-10  2:05 ` Chen, Yu C
2026-08-10 15:53   ` Reinette Chatre
2026-08-10 17:23     ` Chen, Yu C
2026-08-10 18:09       ` Reinette Chatre
2026-08-11  3:49         ` Chen, Yu C
2026-08-13 13:59           ` Chen Yu
2026-08-13 15:19             ` Reinette Chatre
2026-08-10  2:55 ` Fenghua Yu
2026-08-10  3:02   ` Chen, Yu C
2026-08-10  3:25     ` Fenghua Yu
2026-08-10  5:24       ` Chen, Yu C
2026-08-10 15:53   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anS-mmfKYa9kHgGb@agluck-desk3 \
    --to=tony.luck@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=fustini@kernel.org \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®