mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK
@ 2026-07-28  9:53 Wenjia Zhang
  2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Wenjia Zhang @ 2026-07-28  9:53 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Wenjia Zhang

This series enables the Inline Crypto Engine (ICE) hardware for UFS
storage on the Qualcomm X1E80100 (Hamoa IoT EVK) platform.

The ICE hardware provides AES-256-XTS inline encryption/decryption for
UFS storage, offloading cryptographic operations from the CPU. The
hardware version on this platform is ICE v4.0.1 with HWKM v2 support.

Validation:
- Probe successfully
- Standard key work well

Patch 1 adds the new compatible string to the DT binding documentation.
Patch 2 adds the ICE device node to the Hamoa DTSI.

---
Changes in v3:
- Rebased on top of latest linux-next.
- Removed dependency on prerequisite series; all required changes are now
  in mainline.
- Link to v2: https://lore.kernel.org/r/20260722-devtool-v2-0-d7e609ef7388@oss.qualcomm.com

Changes in v2:
- Improve commit messages for both patches.
- Link to v1: https://lore.kernel.org/r/20260721-devtool-v1-0-ade633accb41@oss.qualcomm.com

---
Wenjia Zhang (2):
      dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support
      arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption

 .../bindings/crypto/qcom,inline-crypto-engine.yaml          |  1 +
 arch/arm64/boot/dts/qcom/hamoa.dtsi                         | 13 +++++++++++++
 2 files changed, 14 insertions(+)
---
base-commit: 0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-hamoa_ufs_ice_change-3179799cab79

Best regards,
-- 
Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support
  2026-07-28  9:53 [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Wenjia Zhang
@ 2026-07-28  9:53 ` Wenjia Zhang
  2026-07-30  6:36   ` Krzysztof Kozlowski
  2026-08-10  8:26   ` Herbert Xu
  2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
  2026-11-08 20:21 ` (subset) [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Bjorn Andersson
  2 siblings, 2 replies; 9+ messages in thread
From: Wenjia Zhang @ 2026-07-28  9:53 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Wenjia Zhang

Document the compatible string for inline crypto engine found
on the Qualcomm X1E80100 SoC, used by the Hamoa IoT EVK board.

Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index ed2dd99eb1b120267a20104b4d1cf27a347542c9..23bf98c2b9fa0d415d248d9dd145f16bce961fc8 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -28,6 +28,7 @@ properties:
           - qcom,sm8550-inline-crypto-engine
           - qcom,sm8650-inline-crypto-engine
           - qcom,sm8750-inline-crypto-engine
+          - qcom,x1e80100-inline-crypto-engine
       - const: qcom,inline-crypto-engine
 
   reg:

-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption
  2026-07-28  9:53 [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Wenjia Zhang
  2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
@ 2026-07-28  9:53 ` Wenjia Zhang
  2026-07-29 14:17   ` Konrad Dybcio
                     ` (2 more replies)
  2026-11-08 20:21 ` (subset) [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Bjorn Andersson
  2 siblings, 3 replies; 9+ messages in thread
From: Wenjia Zhang @ 2026-07-28  9:53 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Wenjia Zhang

Add the Inline Crypto Engine (ICE) device node to describe the
hardware-accelerated inline encryption for UFS storage on the
Hamoa IoT EVK board (Qualcomm X1E80100 SoC).

Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/hamoa.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
index 09527dcf957672b4b9658988359e79d8a432fd93..abec577c062d53952528f3bd0330638ea53b83b3 100644
--- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
+++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
@@ -3894,6 +3894,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phys = <&ufs_mem_phy>;
 			phy-names = "ufsphy";
 
+			qcom,ice = <&ice>;
+
 			#reset-cells = <1>;
 
 			status = "disabled";
@@ -3939,6 +3941,17 @@ opp-300000000 {
 			};
 		};
 
+		ice: crypto@1d88000 {
+			compatible = "qcom,x1e80100-inline-crypto-engine",
+				     "qcom,inline-crypto-engine";
+			reg = <0x0 0x01d88000 0x0 0x18000>;
+			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>,
+				 <&gcc GCC_UFS_PHY_AHB_CLK>;
+			clock-names = "core",
+				      "iface";
+			power-domains = <&gcc GCC_UFS_PHY_GDSC>;
+		};
+
 		cryptobam: dma-controller@1dc4000 {
 			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
 			reg = <0x0 0x01dc4000 0x0 0x28000>;

-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption
  2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
@ 2026-07-29 14:17   ` Konrad Dybcio
  2026-08-10 11:52   ` Abel Vesa
  2026-10-08  7:22   ` Wenjia Zhang
  2 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-07-29 14:17 UTC (permalink / raw)
  To: Wenjia Zhang, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel

On 7/28/26 11:53 AM, Wenjia Zhang wrote:
> Add the Inline Crypto Engine (ICE) device node to describe the
> hardware-accelerated inline encryption for UFS storage on the
> Hamoa IoT EVK board (Qualcomm X1E80100 SoC).
> 
> Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support
  2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
@ 2026-07-30  6:36   ` Krzysztof Kozlowski
  2026-08-10  8:26   ` Herbert Xu
  1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-30  6:36 UTC (permalink / raw)
  To: Wenjia Zhang
  Cc: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel

On Tue, Jul 28, 2026 at 05:53:55PM +0800, Wenjia Zhang wrote:
> Document the compatible string for inline crypto engine found
> on the Qualcomm X1E80100 SoC, used by the Hamoa IoT EVK board.
> 
> Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support
  2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
  2026-07-30  6:36   ` Krzysztof Kozlowski
@ 2026-08-10  8:26   ` Herbert Xu
  1 sibling, 0 replies; 9+ messages in thread
From: Herbert Xu @ 2026-08-10  8:26 UTC (permalink / raw)
  To: Wenjia Zhang
  Cc: David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio, linux-arm-msm, linux-crypto,
	devicetree, linux-kernel

On Tue, Jul 28, 2026 at 05:53:55PM +0800, Wenjia Zhang wrote:
> Document the compatible string for inline crypto engine found
> on the Qualcomm X1E80100 SoC, used by the Hamoa IoT EVK board.
> 
> Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption
  2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
  2026-07-29 14:17   ` Konrad Dybcio
@ 2026-08-10 11:52   ` Abel Vesa
  2026-10-08  7:22   ` Wenjia Zhang
  2 siblings, 0 replies; 9+ messages in thread
From: Abel Vesa @ 2026-08-10 11:52 UTC (permalink / raw)
  To: Wenjia Zhang
  Cc: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel

On 26-07-28 17:53:56, Wenjia Zhang wrote:
> Add the Inline Crypto Engine (ICE) device node to describe the
> hardware-accelerated inline encryption for UFS storage on the
> Hamoa IoT EVK board (Qualcomm X1E80100 SoC).
> 
> Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption
  2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
  2026-07-29 14:17   ` Konrad Dybcio
  2026-08-10 11:52   ` Abel Vesa
@ 2026-10-08  7:22   ` Wenjia Zhang
  2 siblings, 0 replies; 9+ messages in thread
From: Wenjia Zhang @ 2026-10-08  7:22 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Bjorn Andersson


On 7/28/2026 5:53 PM, Wenjia Zhang wrote:
> Add the Inline Crypto Engine (ICE) device node to describe the
> hardware-accelerated inline encryption for UFS storage on the
> Hamoa IoT EVK board (Qualcomm X1E80100 SoC).
>
> Signed-off-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/hamoa.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index 09527dcf957672b4b9658988359e79d8a432fd93..abec577c062d53952528f3bd0330638ea53b83b3 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> @@ -3894,6 +3894,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>   			phys = <&ufs_mem_phy>;
>   			phy-names = "ufsphy";
>   
> +			qcom,ice = <&ice>;
> +
>   			#reset-cells = <1>;
>   
>   			status = "disabled";
> @@ -3939,6 +3941,17 @@ opp-300000000 {
>   			};
>   		};
>   
> +		ice: crypto@1d88000 {
> +			compatible = "qcom,x1e80100-inline-crypto-engine",
> +				     "qcom,inline-crypto-engine";
> +			reg = <0x0 0x01d88000 0x0 0x18000>;
> +			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>,
> +				 <&gcc GCC_UFS_PHY_AHB_CLK>;
> +			clock-names = "core",
> +				      "iface";
> +			power-domains = <&gcc GCC_UFS_PHY_GDSC>;
> +		};
> +
>   		cryptobam: dma-controller@1dc4000 {
>   			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
>   			reg = <0x0 0x01dc4000 0x0 0x28000>;

Hi Bjorn,

could you pls help to pick this DT change?

Thanks,

Wenjia Zhang


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: (subset) [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK
  2026-07-28  9:53 [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Wenjia Zhang
  2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
  2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
@ 2026-11-08 20:21 ` Bjorn Andersson
  2 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2026-11-08 20:21 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Konrad Dybcio, Wenjia Zhang
  Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel


On Tue, 28 Jul 2026 17:53:54 +0800, Wenjia Zhang wrote:
> This series enables the Inline Crypto Engine (ICE) hardware for UFS
> storage on the Qualcomm X1E80100 (Hamoa IoT EVK) platform.
> 
> The ICE hardware provides AES-256-XTS inline encryption/decryption for
> UFS storage, offloading cryptographic operations from the CPU. The
> hardware version on this platform is ICE v4.0.1 with HWKM v2 support.
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption
      commit: a4de07fca934ea5de6ddc0eee4ea5bacc60aa0f3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-08 20:25 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-28  9:53 [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Wenjia Zhang
2026-07-28  9:53 ` [PATCH v3 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support Wenjia Zhang
2026-07-30  6:36   ` Krzysztof Kozlowski
2026-08-10  8:26   ` Herbert Xu
2026-07-28  9:53 ` [PATCH v3 2/2] arm64: dts: qcom: hamoa: Add ICE node for UFS inline encryption Wenjia Zhang
2026-07-29 14:17   ` Konrad Dybcio
2026-08-10 11:52   ` Abel Vesa
2026-10-08  7:22   ` Wenjia Zhang
2026-11-08 20:21 ` (subset) [PATCH v3 0/2] Enable ICE for UFS on Hamoa IoT EVK Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®