From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: lorenzo@kernel.org, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH 4/5] iio: humidity: hts221: use dev_err_probe() in probe paths
Date: Mon, 10 Aug 2026 11:45:34 +0300 [thread overview]
Message-ID: <anmPrjxK3ydCtuDS@ashevche-desk.local> (raw)
In-Reply-To: <20260808090026.34187-5-adinata.softwareengineer@gmail.com>
On Sat, Aug 08, 2026 at 05:00:25PM +0800, Adi Nata wrote:
> Convert remaining probe-time error logs to dev_err_probe() so the
> errno is included and deferred probe failures stay quiet.
...
> @@ -579,33 +579,27 @@ int hts221_probe(struct device *dev, int irq, const char *name,
> /* configure humidity sensor */
> err = hts221_parse_rh_caldata(hw);
> - if (err < 0) {
> - dev_err(hw->dev, "failed to get rh calibration data\n");
> - return err;
> - }
> + if (err < 0)
> + return dev_err_probe(hw->dev, err,
> + "failed to get rh calibration data\n");
Why hw->dev and not simply dev?!
Also in all cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-10 8:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 9:00 [PATCH 0/5] iio: humidity: hts221: update probe and logging implementations Adi Nata
2026-08-08 9:00 ` [PATCH 1/5] iio: humidity: hts221: report available values via read_avail() Adi Nata
2026-08-10 0:09 ` Jonathan Cameron
2026-08-12 0:22 ` Adinata Tan
2026-08-12 5:04 ` Jonathan Cameron
2026-08-12 11:40 ` Adinata Tan
2026-08-16 21:58 ` Jonathan Cameron
2026-08-12 0:27 ` Adi
2026-08-08 9:00 ` [PATCH 2/5] iio: humidity: hts221: Add a blank line after variable declarations Adi Nata
2026-08-10 8:40 ` Andy Shevchenko
2026-08-08 9:00 ` [PATCH 3/5] iio: humidity: hts221: Allow unknown whoami for DT fallback Adi Nata
2026-08-10 8:43 ` Andy Shevchenko
2026-08-08 9:00 ` [PATCH 4/5] iio: humidity: hts221: use dev_err_probe() in probe paths Adi Nata
2026-08-10 8:45 ` Andy Shevchenko [this message]
2026-08-12 0:31 ` Adi
2026-08-08 9:00 ` [PATCH 5/5] iio: humidity: hts221: fix division by zero in calibration parsing Adi Nata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anmPrjxK3ydCtuDS@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®