From: Dan Carpenter <error27@gmail.com>
To: Raushan Kumar <mitramaurya80@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c
Date: Wed, 12 Aug 2026 12:06:36 +0300 [thread overview]
Message-ID: <anw3nOfSGKoq-1E_@stanley.mountain> (raw)
In-Reply-To: <20260812085117.103875-1-mitramaurya80@gmail.com>
On Wed, Aug 12, 2026 at 02:21:17PM +0530, Raushan Kumar wrote:
> sysfs attribute show functions are expected to terminate their
> output with a newline. Add the missing \n to the format strings
> in gb_audio_module_name_show(), gb_audio_module_vid_show(),
> gb_audio_module_pid_show(), gb_audio_module_intf_id_show(),
> gb_audio_module_ip_devices_show(), and
> gb_audio_module_op_devices_show(), as flagged by checkpatch.pl.
>
> Signed-off-by: Raushan Kumar <mitramaurya80@gmail.com>
> ---
No, this is user visible API. It's too risky to change once it's been
released.
regards,
dan carpenter
next prev parent reply other threads:[~2026-08-12 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 8:51 Raushan Kumar
2026-08-12 9:06 ` Dan Carpenter [this message]
[not found] <PASTE_MESSAGE_ID_HERE>
2026-08-12 9:26 ` Raushan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anw3nOfSGKoq-1E_@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=mitramaurya80@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®