From: Keith Busch <kbusch@kernel.org>
To: Yao Sang <sangyao@kylinos.cn>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, dwagner@suse.de, hare@suse.de,
johannes.thumshirn@wdc.com, martin.petersen@oracle.com,
javier.gonz@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: fix command effects log lifetime for multipath heads
Date: Tue, 25 Aug 2026 13:00:06 -0600 [thread overview]
Message-ID: <ao3mNp35Hg_0MDlR@kbusch-mbp> (raw)
In-Reply-To: <20260814070651.3973067-1-sangyao@kylinos.cn>
On Fri, Aug 14, 2026 at 03:06:51PM +0800, Yao Sang wrote:
> @@ -4132,6 +4125,12 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
> }
>
> mutex_lock(&ctrl->subsys->lock);
> + ret = nvme_get_effects_log(ctrl, info->ids.csi, &ns->effects);
> + if (ret) {
> + if (ret > 0)
> + ret = blk_status_to_errno(nvme_error_status(ret));
> + goto out_unlock;
> + }
The effects should be the same for every path, so it's a bit wasteful to
copy it for each one. Perhaps it should be just one effects log per
subsystem, per command set, and the head points to that.
prev parent reply other threads:[~2026-08-25 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 7:06 Yao Sang
2026-08-25 19:00 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao3mNp35Hg_0MDlR@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=sangyao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®