From: Christoph Hellwig <hch@infradead.org>
To: Pedro Falcato <pfalcato@suse.de>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Kiryl Shutsemau <kas@kernel.org>,
Lance Yang <lance.yang@linux.dev>,
usama.arif@linux.dev, hughd@google.com,
akpm@linux-foundation.org, baohua@kernel.org,
baolin.wang@linux.alibaba.com, dev.jain@arm.com,
liam@infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, ljs@kernel.org, nico.pache@linux.dev,
ryan.roberts@arm.com, ziy@nvidia.com, nphamcs@gmail.com,
hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev,
kernel-team@meta.com, stable@vger.kernel.org,
willy@infradead.org
Subject: Re: [PATCH] mm/huge_memory: transfer the pmd dirty bit to the folio on zap
Date: Tue, 25 Aug 2026 21:42:33 -0700 [thread overview]
Message-ID: <ao5uudXQVj8JVoG-@infradead.org> (raw)
In-Reply-To: <ao1R1Dh-42ALMq7o@pedro-suse>
On Tue, Aug 25, 2026 at 09:40:31AM +0100, Pedro Falcato wrote:
> That is true. However, I don't think that should stop us from providing
> reasonable semantics for those that use mmap.
>
> Fundamentally:
> - For the common, PTE-level case: we get the granularity for free, the
> filesystem only needs to be notified accordingly.
Where "for free" means that the mapping granularity has to be reduced.
> - For the less common, PMD-level case: we already aggressively break these
> down on mkwrite faults; I think doing this is the right tradeoff. Screw the TLB
> in that case :)
Puh.
> And, frankly, half of the problem (and related to the GUP thread) is that
> page_mkwrite is a crap interface... Something like ->write_begin() being
> generalised to more than read(2)/write(2) could possibly solve most of these
> issues (or a ranged dirty_folio).
I agree that everything around page fault notifications is a mess.
But ->write_begin is worse, it's not even a proper method but a layering
violation that needs to go away (or rather moved out of address_space
directly into the user of generic_perform_write).
next prev parent reply other threads:[~2026-08-26 4:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 10:12 Usama Arif
2026-08-19 14:13 ` David Hildenbrand (Arm)
2026-08-19 14:13 ` David Hildenbrand (Arm)
2026-08-19 14:31 ` Kiryl Shutsemau
2026-08-19 16:17 ` Lance Yang
2026-08-19 16:32 ` Usama Arif
2026-08-20 13:05 ` Usama Arif
2026-08-19 16:35 ` Pedro Falcato
2026-08-20 6:13 ` Lance Yang
2026-08-20 12:12 ` Pedro Falcato
2026-08-20 13:20 ` Kiryl Shutsemau
2026-08-20 14:10 ` Pedro Falcato
2026-08-20 16:53 ` Lance Yang
2026-08-20 22:20 ` Pedro Falcato
2026-08-25 5:59 ` Christoph Hellwig
2026-08-25 8:04 ` David Hildenbrand (Arm)
2026-08-25 8:40 ` Pedro Falcato
2026-08-26 4:42 ` Christoph Hellwig [this message]
2026-08-25 5:57 ` Christoph Hellwig
2026-08-19 20:33 ` Hugh Dickins
2026-08-19 15:10 ` Lance Yang
2026-08-19 15:31 ` Zi Yan
2026-08-19 16:09 ` Lorenzo Stoakes (ARM)
2026-08-20 2:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao5uudXQVj8JVoG-@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®