mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH v1 1/1] drm/i915/gem: Use simpler versions of min*()
Date: Wed, 26 Aug 2026 11:35:07 +0300	[thread overview]
Message-ID: <ao6lOyo5abFmwpN9@ashevche-desk.local> (raw)
In-Reply-To: <ao2bfCVRT8LuOJCb@zenone.zhora.eu>

On Tue, Aug 25, 2026 at 03:44:40PM +0200, Andi Shyti wrote:
> On Tue, Aug 25, 2026 at 11:35:52AM +0200, Andy Shevchenko wrote:

...

> > -		nr_pages = min_array(((unsigned long[]) {
> > -					folio_nr_pages(folio),
> > -					page_count - i,
> > -					max_segment / PAGE_SIZE,
> > -				      }), 3);
> > +		nr_pages = min3(folio_nr_pages(folio),
> > +				page_count - i, max_segment / PAGE_SIZE);
> 
> thanks for your patch, but there is another patch involving (and
> fixing) this line of code[*]. You are welcome to join the review.

Thanks for pointing this out! Do you prefer my to be rebased on top?
Otherwise one can apply this patch first.

> [*] https://patchwork.freedesktop.org/patch/746877/?series=172332&rev=1

Note, my patch doesn't change existing behaviour.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-26  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  9:35 Andy Shevchenko
2026-08-25 13:44 ` Andi Shyti
2026-08-26  8:35   ` Andy Shevchenko [this message]
2026-08-26 16:47     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao6lOyo5abFmwpN9@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®