mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()
@ 2026-08-15  7:01 Raushan Kumar
  2026-08-17  8:38 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Raushan Kumar @ 2026-08-15  7:01 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Mauro Carvalho Chehab, Sakari Ailus, Andy Shevchenko,
	Greg Kroah-Hartman, linux-media, linux-kernel, linux-staging,
	Raushan Kumar

Remove the return statement at the end of the void function
gdc_reg_store(), as it's not needed since the function returns
implicitly, as flagged by checkpatch.pl.

Signed-off-by: Raushan Kumar <mitramaurya80@gmail.com>
---
 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
index b31e3809c0e4..c60f53514553 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
@@ -96,5 +96,4 @@ static inline void gdc_reg_store(
     const hrt_data		value)
 {
 	ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
-	return;
 }
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()
  2026-08-15  7:01 [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store() Raushan Kumar
@ 2026-08-17  8:38 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-08-17  8:38 UTC (permalink / raw)
  To: Raushan Kumar
  Cc: Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
	Andy Shevchenko, Greg Kroah-Hartman, linux-media, linux-kernel,
	linux-staging

On Sat, Aug 15, 2026 at 12:31:05PM +0530, Raushan Kumar wrote:
> Remove the return statement at the end of the void function
> gdc_reg_store(), as it's not needed since the function returns
> implicitly, as flagged by checkpatch.pl.

Is it the only a single leftover in the entire driver?

...

Please, read lore.kernel.org linux-media@ archives against this driver to
understand what to do with this patch.

Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-17  8:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-15  7:01 [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store() Raushan Kumar
2026-08-17  8:38 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®