* [PATCH] drivers: base: test: Depend on OF instead of selecting it
@ 2026-08-17 11:54 Ricardo Ribalda
2026-08-17 15:23 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda @ 2026-08-17 11:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
Andy Shevchenko, Xu Yang
Cc: driver-core, linux-kernel, stable, Ricardo Ribalda
Selecting OF instead of depending on it makes it impossible to
disable OF when KUNIT_ALL_TESTS is selected.
The purpose of KUNIT_ALL_TESTS is to test everything with satisfied
dependencies, not to force dependencies.
Cc: stable@vger.kernel.org
Fixes: 0e6f8ccd4618 ("device property: add test cases for fwnode_for_each_child_node()")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/base/test/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
index 542ce07530a1..292cf33fbaad 100644
--- a/drivers/base/test/Kconfig
+++ b/drivers/base/test/Kconfig
@@ -16,8 +16,7 @@ config DM_KUNIT_TEST
config DRIVER_PE_KUNIT_TEST
tristate "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS
- depends on KUNIT
- select OF
+ depends on KUNIT && OF
default KUNIT_ALL_TESTS
config DRIVER_SWNODE_KUNIT_TEST
---
base-commit: 4477a78374a57c3809b172ad30cceabda48c47c6
change-id: 20260817-driver-pe-50ae7a9abb31
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: base: test: Depend on OF instead of selecting it
2026-08-17 11:54 [PATCH] drivers: base: test: Depend on OF instead of selecting it Ricardo Ribalda
@ 2026-08-17 15:23 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-08-17 15:23 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich, Xu Yang,
driver-core, linux-kernel, stable
On Mon, Aug 17, 2026 at 11:54:44AM +0000, Ricardo Ribalda wrote:
> Selecting OF instead of depending on it makes it impossible to
> disable OF when KUNIT_ALL_TESTS is selected.
>
> The purpose of KUNIT_ALL_TESTS is to test everything with satisfied
> dependencies, not to force dependencies.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Shouldn't we also handle this in tools/testing/kunit/configs/all_tests.config?
(maybe in the future).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-17 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-17 11:54 [PATCH] drivers: base: test: Depend on OF instead of selecting it Ricardo Ribalda
2026-08-17 15:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®