mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	Vivek Pernamitta <vivek.pernamitta@oss.qualcomm.com>,
	Daniele Palmas <dnlplm@gmail.com>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
	Slark Xiao <slark_xiao@163.com>,
	Qiang Yu <qiang.yu@oss.qualcomm.com>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: host: pci_generic: fix usage_count leak when autosuspend_delay is negative
Date: Tue, 18 Aug 2026 11:23:13 +0200	[thread overview]
Message-ID: <aoQkgbI-ZoBTuqe2@hovoldconsulting.com> (raw)
In-Reply-To: <20260808062916.2604668-1-lgs201920130244@gmail.com>

On Sat, Aug 08, 2026 at 02:29:16PM +0800, Guangshuo Li wrote:
> mhi_pci_probe() calls pm_runtime_use_autosuspend() when runtime PM is
> supported, but mhi_pci_remove() does not call the matching
> pm_runtime_dont_use_autosuspend() during device removal.
> 
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during driver teardown, this reference is not dropped and usage_count
> remains unbalanced.

As I've explained elsewhere, this is just misleading. There is no usage
count leak here as the count is balanced whenever the user re-enables
autosuspend through sysfs (by writing a non-negative timeout).

Drivers should clean up after themselves and disable autosuspend, but
this is more of a clean up than a fix and should not be backported.

You've sent upwards of 60 of these in the matter of just a few days,
some of which have even been picked up. Please send follow-ups (replies
or v2s) as soon as possible to prevent further of these from getting
merged.

> Add the missing pm_runtime_dont_use_autosuspend() call before
> forbidding runtime PM.
> 
> This issue was found by manual code inspection.
> 
> Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>

Johan

      reply	other threads:[~2026-08-18  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08  6:29 Guangshuo Li
2026-08-18  9:23 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoQkgbI-ZoBTuqe2@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=dnlplm@gmail.com \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=lgs201920130244@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=qiang.yu@oss.qualcomm.com \
    --cc=slark_xiao@163.com \
    --cc=stable@vger.kernel.org \
    --cc=vivek.pernamitta@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®