* [PATCH] bus: mhi: host: pci_generic: fix usage_count leak when autosuspend_delay is negative
@ 2026-08-08 6:29 Guangshuo Li
2026-08-18 9:23 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Guangshuo Li @ 2026-08-08 6:29 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vivek Pernamitta, Daniele Palmas,
Krishna Chaitanya Chundru, Slark Xiao, Qiang Yu, Loic Poulain,
mhi, linux-arm-msm, linux-kernel
Cc: Guangshuo Li, stable
mhi_pci_probe() calls pm_runtime_use_autosuspend() when runtime PM is
supported, but mhi_pci_remove() does not call the matching
pm_runtime_dont_use_autosuspend() during device removal.
If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
during driver teardown, this reference is not dropped and usage_count
remains unbalanced.
Add the missing pm_runtime_dont_use_autosuspend() call before
forbidding runtime PM.
This issue was found by manual code inspection.
Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/bus/mhi/host/pci_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 0d0d9c7ffa4b..8efff3e0a31c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -1479,6 +1479,7 @@ static void mhi_pci_remove(struct pci_dev *pdev)
struct mhi_pci_device *mhi_pdev = pci_get_drvdata(pdev);
struct mhi_controller *mhi_cntrl = &mhi_pdev->mhi_cntrl;
+ pm_runtime_dont_use_autosuspend(&pdev->dev);
pm_runtime_forbid(&pdev->dev);
pci_disable_sriov(pdev);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: fix usage_count leak when autosuspend_delay is negative
2026-08-08 6:29 [PATCH] bus: mhi: host: pci_generic: fix usage_count leak when autosuspend_delay is negative Guangshuo Li
@ 2026-08-18 9:23 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2026-08-18 9:23 UTC (permalink / raw)
To: Guangshuo Li
Cc: Manivannan Sadhasivam, Vivek Pernamitta, Daniele Palmas,
Krishna Chaitanya Chundru, Slark Xiao, Qiang Yu, Loic Poulain,
mhi, linux-arm-msm, linux-kernel, stable
On Sat, Aug 08, 2026 at 02:29:16PM +0800, Guangshuo Li wrote:
> mhi_pci_probe() calls pm_runtime_use_autosuspend() when runtime PM is
> supported, but mhi_pci_remove() does not call the matching
> pm_runtime_dont_use_autosuspend() during device removal.
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during driver teardown, this reference is not dropped and usage_count
> remains unbalanced.
As I've explained elsewhere, this is just misleading. There is no usage
count leak here as the count is balanced whenever the user re-enables
autosuspend through sysfs (by writing a non-negative timeout).
Drivers should clean up after themselves and disable autosuspend, but
this is more of a clean up than a fix and should not be backported.
You've sent upwards of 60 of these in the matter of just a few days,
some of which have even been picked up. Please send follow-ups (replies
or v2s) as soon as possible to prevent further of these from getting
merged.
> Add the missing pm_runtime_dont_use_autosuspend() call before
> forbidding runtime PM.
>
> This issue was found by manual code inspection.
>
> Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-18 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-08 6:29 [PATCH] bus: mhi: host: pci_generic: fix usage_count leak when autosuspend_delay is negative Guangshuo Li
2026-08-18 9:23 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®