From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Li Jun <lijun01@kylinos.cn>
Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com,
bhelgaas@google.com, u.kleine-koenig@baylibre.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: pm: use SIMPLE_DEV_PM_OPS for pm struct
Date: Wed, 19 Aug 2026 10:55:36 +0300 [thread overview]
Message-ID: <aoVheCwh936pxh1F@ashevche-desk.local> (raw)
In-Reply-To: <20260819033142.2127526-1-lijun01@kylinos.cn>
On Wed, Aug 19, 2026 at 11:31:42AM +0800, Li Jun wrote:
> use SIMPLE_DEV_PM_OPS for charlcd_pm_ops,and add the value of
> .freeze .thaw .poweroff .restore.
Respect English grammar and punctuation.
...
> -static const struct dev_pm_ops charlcd_pm_ops = {
> - .suspend = charlcd_suspend,
> - .resume = charlcd_resume,
> -};
> +static SIMPLE_DEV_PM_OPS(charlcd_pm_ops, charlcd_suspend, charlcd_resume);
No, see what it says about this
https://elixir.bootlin.com/linux/v7.2/source/include/linux/pm.h#L436
Use DEFINE_SIMPLE_DEV_PM_OPS() and the respective pm_sleep_ptr() macro.
...
Hint: there are tons of patches like this in the Git history for the last few
years, just grep over them to see the examples how this change should look
like.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-19 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 3:31 Li Jun
2026-08-19 7:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoVheCwh936pxh1F@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=fourier.thomas@gmail.com \
--cc=geert@linux-m68k.org \
--cc=lijun01@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®