mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Mohamed Khalfella <mkhalfella@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: add opcode filtering for fault injection
Date: Wed, 19 Aug 2026 09:33:23 -0600	[thread overview]
Message-ID: <aoXMw1CKFlecrXU0@kbusch-mbp> (raw)
In-Reply-To: <20260811231152.1138761-1-mkhalfella@purestorage.com>

On Tue, Aug 11, 2026 at 04:11:52PM -0700, Mohamed Khalfella wrote:
> Currently NVMe fault injection applies to every command routed through
> nvme_should_fail(), which makes it hard to target a specific command
> type when reproducing an issue in error-handling paths.
> 
> Add an "opcode" debugfs attribute alongside the existing "status" and
> "dont_retry" knobs. It defaults to 0xffff, meaning "match any opcode"
> and preserving the previous behavior. When set to a valid opcode
> (<= 0xff), fault injection is only considered for commands whose opcode
> matches.

Thanks, applied to nvme-7.3.

  parent reply	other threads:[~2026-08-19 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 23:11 Mohamed Khalfella
2026-08-17  8:19 ` Christoph Hellwig
2026-08-19 15:33 ` Keith Busch [this message]
2026-08-22 22:49 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoXMw1CKFlecrXU0@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mkhalfella@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®