mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
@ 2026-08-20  2:14 Chancel Liu
  2026-08-20 13:47 ` Alvin Šipraga
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chancel Liu @ 2026-08-20  2:14 UTC (permalink / raw)
  To: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
	broonie, perex, tiwai
  Cc: Frank.Li, linuxppc-dev, linux-sound, linux-kernel

From: Chancel Liu <chancel.liu@nxp.com>

Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
from the "Playback" stream. This allows external amplifiers connected
to the MQS outputs to be properly linked into the DAPM graph, so their
power state can follow the playback stream.

Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
 sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index 901f840df904..5b00488253bb 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
 			   mqs_priv->soc->en_mask, 0);
 }
 
+static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
+	SND_SOC_DAPM_OUTPUT("MQS_L"),
+	SND_SOC_DAPM_OUTPUT("MQS_R"),
+};
+
+static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
+	{ "MQS_L", NULL, "Playback" },
+	{ "MQS_R", NULL, "Playback" },
+};
+
 static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
+	.dapm_widgets = fsl_mqs_dapm_widgets,
+	.num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
+	.dapm_routes = fsl_mqs_dapm_routes,
+	.num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
 	.idle_bias_on = 1,
 };
 
-- 
2.50.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
  2026-08-20  2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
@ 2026-08-20 13:47 ` Alvin Šipraga
  2026-08-20 15:48 ` Frank Li
  2026-08-30 22:26 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Alvin Šipraga @ 2026-08-20 13:47 UTC (permalink / raw)
  To: Chancel Liu
  Cc: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
	broonie, perex, tiwai, Frank.Li, linuxppc-dev, linux-sound,
	linux-kernel

On Thu, Aug 20, 2026 at 11:14:53AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
> 
> Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
> from the "Playback" stream. This allows external amplifiers connected
> to the MQS outputs to be properly linked into the DAPM graph, so their
> power state can follow the playback stream.
> 
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>

> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index 901f840df904..5b00488253bb 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
>  			   mqs_priv->soc->en_mask, 0);
>  }
>  
> +static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
> +	SND_SOC_DAPM_OUTPUT("MQS_L"),
> +	SND_SOC_DAPM_OUTPUT("MQS_R"),
> +};
> +
> +static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
> +	{ "MQS_L", NULL, "Playback" },
> +	{ "MQS_R", NULL, "Playback" },
> +};
> +
>  static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> +	.dapm_widgets = fsl_mqs_dapm_widgets,
> +	.num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
> +	.dapm_routes = fsl_mqs_dapm_routes,
> +	.num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
>  	.idle_bias_on = 1,
>  };
>  
> -- 
> 2.50.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
  2026-08-20  2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
  2026-08-20 13:47 ` Alvin Šipraga
@ 2026-08-20 15:48 ` Frank Li
  2026-08-30 22:26 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-08-20 15:48 UTC (permalink / raw)
  To: Chancel Liu
  Cc: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
	broonie, perex, tiwai, Frank.Li, linuxppc-dev, linux-sound,
	linux-kernel

On Thu, Aug 20, 2026 at 11:14:53AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
> from the "Playback" stream. This allows external amplifiers connected
> to the MQS outputs to be properly linked into the DAPM graph, so their
> power state can follow the playback stream.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index 901f840df904..5b00488253bb 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
>  			   mqs_priv->soc->en_mask, 0);
>  }
>
> +static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
> +	SND_SOC_DAPM_OUTPUT("MQS_L"),
> +	SND_SOC_DAPM_OUTPUT("MQS_R"),
> +};
> +
> +static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
> +	{ "MQS_L", NULL, "Playback" },
> +	{ "MQS_R", NULL, "Playback" },
> +};
> +
>  static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> +	.dapm_widgets = fsl_mqs_dapm_widgets,
> +	.num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
> +	.dapm_routes = fsl_mqs_dapm_routes,
> +	.num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
>  	.idle_bias_on = 1,
>  };
>
> --
> 2.50.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
  2026-08-20  2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
  2026-08-20 13:47 ` Alvin Šipraga
  2026-08-20 15:48 ` Frank Li
@ 2026-08-30 22:26 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-08-30 22:26 UTC (permalink / raw)
  To: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
	perex, tiwai, Chancel Liu
  Cc: Frank.Li, linuxppc-dev, linux-sound, linux-kernel

On Thu, 20 Aug 2026 11:14:53 +0900, Chancel Liu wrote:
> ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
      https://git.kernel.org/broonie/sound/c/040a7beba8bf

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-01 18:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-20  2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
2026-08-20 13:47 ` Alvin Šipraga
2026-08-20 15:48 ` Frank Li
2026-08-30 22:26 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®