From: Mike Rapoport <rppt@kernel.org>
To: LongWei27 <longwei27@huawei.com>
Cc: Alexander Graf <graf@amazon.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hewenliang4@huawei.com
Subject: Re: [PATCH] kho: Convert error handling to immediate return pattern
Date: Sun, 23 Aug 2026 10:39:23 +0300 [thread overview]
Message-ID: <aoqjq4kLCCSJtdP8@kernel.org> (raw)
In-Reply-To: <20260822064127.498411-1-longwei27@huawei.com>
Hi,
On Sat, Aug 22, 2026 at 02:41:27PM +0800, LongWei27 wrote:
> From: Long Wei <longwei27@huawei.com>
>
> Replace the chained error accumulation (err |= func()) with immediate
> per-step error checking and early return in kho_out_fdt_setup().
You didn't explain *why* are you doing it.
> Signed-off-by: Long Wei <longwei27@huawei.com>
> ---
> kernel/liveupdate/kexec_handover.c | 32 +++++++++++++++++++++---------
> 1 file changed, 23 insertions(+), 9 deletions(-)
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-08-23 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 6:41 LongWei27
2026-08-23 7:39 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoqjq4kLCCSJtdP8@kernel.org \
--to=rppt@kernel.org \
--cc=graf@amazon.com \
--cc=hewenliang4@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longwei27@huawei.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®