mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] staging: rtl8723bs: fix space before tab in comments
       [not found] <20260823-b4-rtl8723bs-cmd-xmit-space-before-tab-fix-v1-0-11f2600e470a.ref@yahoo.pl>
@ 2026-08-23 16:46 ` Tomasz Unger
  2026-08-23 16:46   ` [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
  2026-08-23 16:46   ` [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment Tomasz Unger
  0 siblings, 2 replies; 5+ messages in thread
From: Tomasz Unger @ 2026-08-23 16:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Tomasz Unger

Remove stray spaces before tabs in two comments in the rtl8723bs
driver, found while auditing drivers/staging for whitespace issues.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Tomasz Unger (2):
      staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
      staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment

 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c      | 2 +-
 drivers/staging/rtl8723bs/include/rtl8723b_xmit.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: c6eb4dc5964fdf4086b73b7f0f5dc0d595fb5cf3
change-id: 20260823-b4-rtl8723bs-cmd-xmit-space-before-tab-fix-4d4c2e023a54

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
  2026-08-23 16:46 ` [PATCH 0/2] staging: rtl8723bs: fix space before tab in comments Tomasz Unger
@ 2026-08-23 16:46   ` Tomasz Unger
  2026-08-23 17:02     ` tomasz.unger
  2026-08-23 16:46   ` [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment Tomasz Unger
  1 sibling, 1 reply; 5+ messages in thread
From: Tomasz Unger @ 2026-08-23 16:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Tomasz Unger

Remove a stray space before a tab in a comment.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Verified with checkpatch.pl - no new warnings introduced by this change.
---
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index d2b44ad60a4c..5f6eabc76562 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -895,7 +895,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter)
 		DLBcnCount++;
 		do {
 			yield();
-/* 			mdelay(10); */
+/*			mdelay(10); */
 			/*  check rsvd page download OK. */
 			rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid);
 			poll++;

-- 
2.55.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment
  2026-08-23 16:46 ` [PATCH 0/2] staging: rtl8723bs: fix space before tab in comments Tomasz Unger
  2026-08-23 16:46   ` [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
@ 2026-08-23 16:46   ` Tomasz Unger
  2026-08-23 19:07     ` Dan Carpenter
  1 sibling, 1 reply; 5+ messages in thread
From: Tomasz Unger @ 2026-08-23 16:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Tomasz Unger

Remove a stray space before a tab in a comment.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Verified with checkpatch.pl - no new warnings introduced by this change.
---
 drivers/staging/rtl8723bs/include/rtl8723b_xmit.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
index ddf868c7899b..c2b5696554fe 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
@@ -366,7 +366,7 @@ struct txdesc_8723b {
 #endif
 /*  */
 /*  */
-/* 	Rate */
+/*	Rate */
 /*  */
 /*  */
 /*  CCK Rates, TxHT = 0 */

-- 
2.55.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
  2026-08-23 16:46   ` [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
@ 2026-08-23 17:02     ` tomasz.unger
  0 siblings, 0 replies; 5+ messages in thread
From: tomasz.unger @ 2026-08-23 17:02 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel

Please disregard this patch (1/2 of this series).

I already sent a fix for this exact same line earlier today, in an
unrelated, separate submission:

  "staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment"
  Message-Id: <20260823-rtl8723b-cmd-space-before-tab-fix-v1-1-452d83d8718c@yahoo.pl>

I did not check for an existing pending fix to this line before
preparing today's series - sorry for the duplicate noise.

Patch 2/2 of this series (rtl8723b_xmit.h) is unrelated and still
applies independently.

Noted on the series point too - going forward I'll send related
patches (not just for rtl8723bs) as a single series with a cover
letter.

Regards,
Tomasz

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment
  2026-08-23 16:46   ` [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment Tomasz Unger
@ 2026-08-23 19:07     ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-08-23 19:07 UTC (permalink / raw)
  To: Tomasz Unger; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel

On Sun, Aug 23, 2026 at 06:46:32PM +0200, Tomasz Unger wrote:
> Remove a stray space before a tab in a comment.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Verified with checkpatch.pl - no new warnings introduced by this change.
> ---
>  drivers/staging/rtl8723bs/include/rtl8723b_xmit.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
> index ddf868c7899b..c2b5696554fe 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
> @@ -366,7 +366,7 @@ struct txdesc_8723b {
>  #endif
>  /*  */
>  /*  */
> -/* 	Rate */
> +/*	Rate */
>  /*  */
>  /*  */

I'm not sure that these comments after #ifdef add any value at all.

regards,
dan carpenter

>  /*  CCK Rates, TxHT = 0 */
> 
> -- 
> 2.55.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-23 19:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20260823-b4-rtl8723bs-cmd-xmit-space-before-tab-fix-v1-0-11f2600e470a.ref@yahoo.pl>
2026-08-23 16:46 ` [PATCH 0/2] staging: rtl8723bs: fix space before tab in comments Tomasz Unger
2026-08-23 16:46   ` [PATCH 1/2] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
2026-08-23 17:02     ` tomasz.unger
2026-08-23 16:46   ` [PATCH 2/2] staging: rtl8723bs: fix space before tab in rtl8723b_xmit.h comment Tomasz Unger
2026-08-23 19:07     ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®