mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Tsz Shan Chan" <tsz.chan.dev@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Tsz Shan Chan" <tchan@jacques.com.au>
Subject: Re: [PATCH v2 2/2] iio: light: vcnl4000: add shared IRQ support
Date: Mon, 24 Aug 2026 11:24:26 +0300	[thread overview]
Message-ID: <aov_uhPCcno0YJTe@ashevche-desk.local> (raw)
In-Reply-To: <20260822032550.31a0fa9e@jic23-huawei>

On Sat, Aug 22, 2026 at 03:25:50AM +0100, Jonathan Cameron wrote:
> On Fri, 14 Aug 2026 14:30:43 +1000
> Tsz Shan Chan <tsz.chan.dev@gmail.com> wrote:

> > The INT output of vcnl4010/4020 and vcnl4040/4200 is open drain active
> > low which can be shared with other devices.
> > Add IRQF_SHARED and switch the trigger type from IRQF_TRIGGER_FALLING to
> > IRQF_TRIGGER_LOW. Edge triggering can miss interrupts on a shared line.
> Fairly low risk change but I guess we'll see.
> 
> It used to be annoyingly common for interrupt controllers to support
> only edge based interrupts, but hopefully that silliness is a thing
> of the past.
> 
> So crossed fingers, I'll apply this and see if we get anyone shouting.
> I think we'll get away with it

In another thread somebody mentioned a type of the signal that HW generates.
Having OD output doesn't prevent HW to behave like it does edge interrupts,
id est generating a pulse instead of keeping the level until it gets acked.
With that being said, I would ask the datasheet citation to clarify the case.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-24  8:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  4:30 [PATCH v2 0/2] iio: light: vcnl4000: support shared IRQs Tsz Shan Chan
2026-08-14  4:30 ` [PATCH v2 1/2] iio: light: vcnl4000: use correct channel array size Tsz Shan Chan
2026-08-14  4:30 ` [PATCH v2 2/2] iio: light: vcnl4000: add shared IRQ support Tsz Shan Chan
2026-08-22  2:25   ` Jonathan Cameron
2026-08-24  8:24     ` Andy Shevchenko [this message]
2026-08-25  3:22       ` Tsz Shan Chan
2026-08-17 10:55 ` [PATCH v2 0/2] iio: light: vcnl4000: support shared IRQs Andy Shevchenko
2026-08-22  2:29   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aov_uhPCcno0YJTe@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=tchan@jacques.com.au \
    --cc=tsz.chan.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®