From: Dan Carpenter <error27@gmail.com>
To: Samrudh Nelli <samrudhnelli@gmail.com>
Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com,
azpijr@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] staging: rtl8723bs: modernize locking with cleanup.h
Date: Mon, 24 Aug 2026 09:53:17 +0300 [thread overview]
Message-ID: <aovqXYJ_96AyG2aN@stanley.mountain> (raw)
In-Reply-To: <cover.1787421961.git.samrudhnelli@gmail.com>
On Sat, Aug 22, 2026 at 11:53:45PM +0530, Samrudh Nelli wrote:
> This series modernizes the mutex locking in rtw_pwrctrl.c by utilizing
> the guard() and scoped_guard() macros introduced in cleanup.h.
>
> Patch 1 converts functions where the lock is held until returning.
> Patch 2 converts functions where the lock is dropped mid-execution.
>
> Samrudh Nelli (2):
> staging: rtl8723bs: use guard(mutex) to simplify locking
> staging: rtl8723bs: use scoped_guard() for mid-function locking
We're not doing this sort of change to existing code unless it's part
of a bugfix. It's just a lot of churn.
regards,
dan carpenter
prev parent reply other threads:[~2026-08-24 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 18:23 Samrudh Nelli
2026-08-22 18:23 ` [PATCH 1/2] staging: rtl8723bs: use guard(mutex) to simplify locking Samrudh Nelli
2026-08-22 18:23 ` [PATCH 2/2] staging: rtl8723bs: use scoped_guard() for mid-function locking Samrudh Nelli
2026-08-24 6:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aovqXYJ_96AyG2aN@stanley.mountain \
--to=error27@gmail.com \
--cc=azpijr@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=samrudhnelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®