From: "Shengzhuo Wei" <me@cherr.cc>
To: "Breno Leitao" <leitao@debian.org>
Cc: "Shengzhuo Wei" <me@cherr.cc>,
"Chris Snook" <chris.snook@gmail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Tony Zelenoff" <antonz@parallels.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] atlx: atl1: cancel reset and link works on remove
Date: Fri, 28 Aug 2026 18:16:22 +0800 [thread overview]
Message-ID: <apFf9i99-DxoVqpd@pve> (raw)
In-Reply-To: <apFZbMGEnfRRz2IF@gmail.com>
On 2026-08-28 02:49, Breno Leitao wrote:
> Is 03662e41c7cf the right commit to blame?
>
> Both works, and the unregister_netdev()/free_netdev() sequence with no
> cancel, came in with the initial driver in f3cc28c79760 ("Add Attansic
> L1 ethernet driver."), no?
You are right, thanks. 03662e41c7cf only renamed tx_timeout_task to
reset_dev_task; the link_chg_task, and the remove path with no
cancellation of either work, are already in the initial import.
v2 points Fixes at f3cc28c79760.
--
Shengzhuo Wei
prev parent reply other threads:[~2026-08-28 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 7:48 Shengzhuo Wei
2026-08-28 9:49 ` Breno Leitao
2026-08-28 10:16 ` Shengzhuo Wei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apFf9i99-DxoVqpd@pve \
--to=me@cherr.cc \
--cc=andrew+netdev@lunn.ch \
--cc=antonz@parallels.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®