* [PATCH 1/9] arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 2/9] arm64: dts: qcom: x1e001de-devkit: " Abel Vesa
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the Embedded Controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index 60db83b8985f..d1bed84725e8 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -1531,6 +1531,7 @@ right_tweeter: speaker@0,1 {
&tlmm {
gpio-reserved-ranges = <34 2>, /* Unused */
<44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
ec_int_n_default: ec-int-n-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 2/9] arm64: dts: qcom: x1e001de-devkit: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
2026-08-31 9:54 ` [PATCH 1/9] arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 3/9] arm64: dts: qcom: x1e78100-t14s: " Abel Vesa
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 7b8a31e82b87 ("arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index be1a8ac8c699..3ba45a7884a2 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -1194,7 +1194,8 @@ wcd_tx: codec@0,3 {
};
&tlmm {
- gpio-reserved-ranges = <44 4>; /* SPI (TPM) */
+ gpio-reserved-ranges = <44 4>, /* SPI (TPM) */
+ <65 1>; /* EC reset */
eusb3_reset_n: eusb3-reset-n-state {
pins = "gpio6";
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 3/9] arm64: dts: qcom: x1e78100-t14s: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
2026-08-31 9:54 ` [PATCH 1/9] arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved Abel Vesa
2026-08-31 9:54 ` [PATCH 2/9] arm64: dts: qcom: x1e001de-devkit: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Abel Vesa
` (7 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 0bee2a3d6e7a..8f7b01617461 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -1385,6 +1385,7 @@ wcd_tx: codec@0,3 {
&tlmm {
gpio-reserved-ranges = <34 2>, /* Unused */
<44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<72 2>, /* Secure EC I2C connection (?) */
<238 1>; /* UFS Reset */
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (2 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 3/9] arm64: dts: qcom: x1e78100-t14s: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 12:00 ` Aleksandrs Vinarskis
2026-08-31 9:54 ` [PATCH 5/9] arm64: dts: qcom: honor-magicbook-art-14: " Abel Vesa
` (6 subsequent siblings)
10 siblings, 1 reply; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
index 2be5a37c00cc..b795b65d604e 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
@@ -1072,6 +1072,7 @@ &smb2360_1_eusb2_repeater {
&tlmm {
gpio-reserved-ranges = <44 4>, /* SPI11 (TPM) */
<76 4>, /* SPI19 (TZ Protected) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
cam_indicator_en: cam-indicator-en-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
2026-08-31 9:54 ` [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Abel Vesa
@ 2026-08-31 12:00 ` Aleksandrs Vinarskis
2026-08-31 13:44 ` Abel Vesa
0 siblings, 1 reply; 17+ messages in thread
From: Aleksandrs Vinarskis @ 2026-08-31 12:00 UTC (permalink / raw)
To: Abel Vesa
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On Mon, 31 Aug 2026 at 12:05, Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
>
> GPIO 65 from TLMM is used by the embedded controller as its reset line.
> Reserve it to prevent Linux from requesting or reconfiguring it.
>
> Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Hi Abel,
For XPS 9345 this change is already included in my series for EC driver:
https://lore.kernel.org/all/20260809-dell-xps-9345-ec-v4-0-88306dbbc7aa@vinarskis.com/
To avoid conflict, could you drop the XPS 9345 from your series? I'm hoping my
change will land shortly, its already reviewed.
Thanks,
Alex
> ---
> arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index 2be5a37c00cc..b795b65d604e 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> @@ -1072,6 +1072,7 @@ &smb2360_1_eusb2_repeater {
> &tlmm {
> gpio-reserved-ranges = <44 4>, /* SPI11 (TPM) */
> <76 4>, /* SPI19 (TZ Protected) */
> + <65 1>, /* EC reset */
> <238 1>; /* UFS Reset */
>
> cam_indicator_en: cam-indicator-en-state {
>
> --
> 2.54.0
>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
2026-08-31 12:00 ` Aleksandrs Vinarskis
@ 2026-08-31 13:44 ` Abel Vesa
0 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 13:44 UTC (permalink / raw)
To: Aleksandrs Vinarskis
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On 26-08-31 14:00:35, Aleksandrs Vinarskis wrote:
> On Mon, 31 Aug 2026 at 12:05, Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
> >
> > GPIO 65 from TLMM is used by the embedded controller as its reset line.
> > Reserve it to prevent Linux from requesting or reconfiguring it.
> >
> > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
>
> Hi Abel,
>
> For XPS 9345 this change is already included in my series for EC driver:
> https://lore.kernel.org/all/20260809-dell-xps-9345-ec-v4-0-88306dbbc7aa@vinarskis.com/
>
> To avoid conflict, could you drop the XPS 9345 from your series? I'm hoping my
> change will land shortly, its already reviewed.
If your change lands first, then I'll drop the xps13 patch.
But yours does not have fixes tag nor should it since it is just
adjacent to your EC enablement.
This fix of mine needs to be backported as having the gpio controllable
messes up EC in such a way where you need to unplug the battery on some
devices.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/9] arm64: dts: qcom: honor-magicbook-art-14: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (3 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 4/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 6/9] arm64: dts: qcom: x1e80100-yoga-slim7x: " Abel Vesa
` (5 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 21b15fa5f8f4 ("arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
index b70c1e094bbf..a14f0d0632f0 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
@@ -1068,7 +1068,8 @@ right_tweeter: speaker@0,1 {
&tlmm {
gpio-reserved-ranges = <34 2>, /* Unused */
- <44 4>; /* SPI (TPM) */
+ <44 4>, /* SPI (TPM) */
+ <65 1>; /* EC reset */
tpad_default: tpad-default-state {
pins = "gpio3";
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 6/9] arm64: dts: qcom: x1e80100-yoga-slim7x: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (4 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 5/9] arm64: dts: qcom: honor-magicbook-art-14: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 7/9] arm64: dts: qcom: medion-sprchrgd-14-s1: " Abel Vesa
` (4 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 9eb2dfd99f20..3e4ab58d2f6f 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -1350,6 +1350,7 @@ right_tweeter: speaker@0,1 {
&tlmm {
gpio-reserved-ranges = <34 2>, /* Unused */
<44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
edp_reg_en: edp-reg-en-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 7/9] arm64: dts: qcom: medion-sprchrgd-14-s1: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (5 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 6/9] arm64: dts: qcom: x1e80100-yoga-slim7x: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 8/9] arm64: dts: qcom: microsoft-romulus: " Abel Vesa
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 8cf65490cdb0 ("arm64: dts: qcom: Add dts for Medion SPRCHRGD 14 S1")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts b/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
index e4a0b86847cd..4b45f293e167 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
@@ -1251,6 +1251,7 @@ right_tweeter: speaker@0,1 {
&tlmm {
gpio-reserved-ranges = <28 4>, /* Unused */
<44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
edp_reg_en: edp-reg-en-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 8/9] arm64: dts: qcom: microsoft-romulus: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (6 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 7/9] arm64: dts: qcom: medion-sprchrgd-14-s1: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 9:54 ` [PATCH 9/9] arm64: dts: qcom: x1e80100-qcp: " Abel Vesa
` (2 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index 13d0f09e0c2a..bc684c295b89 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -1324,6 +1324,7 @@ wcd_tx: codec@0,3 {
&tlmm {
gpio-reserved-ranges = <44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
hall_int_n_default: hall-int-n-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 9/9] arm64: dts: qcom: x1e80100-qcp: Mark the EC reset gpio as reserved
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (7 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 8/9] arm64: dts: qcom: microsoft-romulus: " Abel Vesa
@ 2026-08-31 9:54 ` Abel Vesa
2026-08-31 10:12 ` [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
2026-08-31 15:07 ` Bjorn Andersson
10 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Konrad Dybcio, Abel Vesa
GPIO 65 from TLMM is used by the embedded controller as its reset line.
Reserve it to prevent Linux from requesting or reconfiguring it.
Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 78380fec8839..19ea1add016c 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -1180,6 +1180,7 @@ wcd_tx: codec@0,3 {
&tlmm {
gpio-reserved-ranges = <33 3>, /* Unused */
<44 4>, /* SPI (TPM) */
+ <65 1>, /* EC reset */
<238 1>; /* UFS Reset */
edp_reg_en: edp-reg-en-state {
--
2.54.0
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (8 preceding siblings ...)
2026-08-31 9:54 ` [PATCH 9/9] arm64: dts: qcom: x1e80100-qcp: " Abel Vesa
@ 2026-08-31 10:12 ` Abel Vesa
2026-08-31 15:04 ` Bjorn Andersson
2026-08-31 15:07 ` Bjorn Andersson
10 siblings, 1 reply; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 10:12 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Abel Vesa, Rajendra Nayak,
Marc Zyngier, Aleksandrs Vinarskis, Konstantin Shabanov,
Srinivas Kandagatla, Georg Gottleuber, Ettore Chimenti
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio, Konrad Dybcio
On 26-08-31 12:54:40, Abel Vesa wrote:
> GPIO 65 from TLMM is used by the embedded controller as its reset line on
> these boards. Reserve it to prevent Linux from requesting or reconfiguring it.
>
> I was only able to confirm that this GPIO is actually connected to the
> EC reset on the CRD, QCP, xps13 and t14s. But it seems like it is
> recurring them shared between all Hamoa based devices, so I reserved it
> on all.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Abel Vesa (9):
> arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e001de-devkit: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e78100-t14s: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
> arm64: dts: qcom: honor-magicbook-art-14: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-yoga-slim7x: Mark the EC reset gpio as reserved
> arm64: dts: qcom: medion-sprchrgd-14-s1: Mark the EC reset gpio as reserved
> arm64: dts: qcom: microsoft-romulus: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-qcp: Mark the EC reset gpio as reserved
>
> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 ++-
> arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts | 3 ++-
> arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 +
> 9 files changed, 11 insertions(+), 2 deletions(-)
Urgh, just realized that there way more that need to be addressed.
Will do that in v2, after I get some reviews.
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards
2026-08-31 10:12 ` [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
@ 2026-08-31 15:04 ` Bjorn Andersson
2026-08-31 15:40 ` Abel Vesa
0 siblings, 1 reply; 17+ messages in thread
From: Bjorn Andersson @ 2026-08-31 15:04 UTC (permalink / raw)
To: Abel Vesa
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sibi Sankar, Abel Vesa, Rajendra Nayak, Marc Zyngier,
Aleksandrs Vinarskis, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On Mon, Aug 31, 2026 at 01:12:38PM +0300, Abel Vesa wrote:
> On 26-08-31 12:54:40, Abel Vesa wrote:
> > GPIO 65 from TLMM is used by the embedded controller as its reset line on
> > these boards. Reserve it to prevent Linux from requesting or reconfiguring it.
> >
> > I was only able to confirm that this GPIO is actually connected to the
> > EC reset on the CRD, QCP, xps13 and t14s. But it seems like it is
> > recurring them shared between all Hamoa based devices, so I reserved it
> > on all.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > ---
> > Abel Vesa (9):
> > arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: x1e001de-devkit: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: x1e78100-t14s: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: honor-magicbook-art-14: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: x1e80100-yoga-slim7x: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: medion-sprchrgd-14-s1: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: microsoft-romulus: Mark the EC reset gpio as reserved
> > arm64: dts: qcom: x1e80100-qcp: Mark the EC reset gpio as reserved
> >
> > arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
> > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 ++-
> > arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
> > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
> > arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts | 3 ++-
> > arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
> > arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 1 +
> > arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 +
> > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 +
> > 9 files changed, 11 insertions(+), 2 deletions(-)
>
> Urgh, just realized that there way more that need to be addressed.
>
I'm not able to guess what you're referring to here. More devices or
more problems to fix? If more devices, why would that warrant a v2?
> Will do that in v2, after I get some reviews.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards
2026-08-31 15:04 ` Bjorn Andersson
@ 2026-08-31 15:40 ` Abel Vesa
0 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 15:40 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sibi Sankar, Abel Vesa, Rajendra Nayak, Marc Zyngier,
Aleksandrs Vinarskis, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On 26-08-31 10:04:41, Bjorn Andersson wrote:
> On Mon, Aug 31, 2026 at 01:12:38PM +0300, Abel Vesa wrote:
> > On 26-08-31 12:54:40, Abel Vesa wrote:
> > > GPIO 65 from TLMM is used by the embedded controller as its reset line on
> > > these boards. Reserve it to prevent Linux from requesting or reconfiguring it.
> > >
> > > I was only able to confirm that this GPIO is actually connected to the
> > > EC reset on the CRD, QCP, xps13 and t14s. But it seems like it is
> > > recurring them shared between all Hamoa based devices, so I reserved it
> > > on all.
> > >
> > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > > ---
> > > Abel Vesa (9):
> > > arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: x1e001de-devkit: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: x1e78100-t14s: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: honor-magicbook-art-14: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: x1e80100-yoga-slim7x: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: medion-sprchrgd-14-s1: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: microsoft-romulus: Mark the EC reset gpio as reserved
> > > arm64: dts: qcom: x1e80100-qcp: Mark the EC reset gpio as reserved
> > >
> > > arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
> > > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 ++-
> > > arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
> > > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
> > > arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts | 3 ++-
> > > arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
> > > arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 1 +
> > > arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 +
> > > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 +
> > > 9 files changed, 11 insertions(+), 2 deletions(-)
> >
> > Urgh, just realized that there way more that need to be addressed.
> >
>
> I'm not able to guess what you're referring to here. More devices or
> more problems to fix? If more devices, why would that warrant a v2?
IMO, the fact that the comment is under a bunch of filenames, should be
pretty obvious that there are more devices, especially since this entire
patchset is fixing same kind of problem for all of these boards.
Anyway, will be more explicit next time.
As for v2, it doesn't warrant one, but I was telling reviewers that I
realized that there are more than just these devices that need this fixed,
basically promising to fix all and include them in v2, if a respin is
necessary. Which it might, if you merge Alex's EC XPS13 patchset first.
Thanks for reviewing!
Abel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards
2026-08-31 9:54 [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
` (9 preceding siblings ...)
2026-08-31 10:12 ` [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards Abel Vesa
@ 2026-08-31 15:07 ` Bjorn Andersson
2026-08-31 15:34 ` Abel Vesa
10 siblings, 1 reply; 17+ messages in thread
From: Bjorn Andersson @ 2026-08-31 15:07 UTC (permalink / raw)
To: Abel Vesa
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sibi Sankar, Abel Vesa, Rajendra Nayak, Marc Zyngier,
Aleksandrs Vinarskis, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On Mon, Aug 31, 2026 at 12:54:40PM +0300, Abel Vesa wrote:
> GPIO 65 from TLMM is used by the embedded controller as its reset line on
> these boards. Reserve it to prevent Linux from requesting or reconfiguring it.
>
> I was only able to confirm that this GPIO is actually connected to the
> EC reset on the CRD, QCP, xps13 and t14s. But it seems like it is
> recurring them shared between all Hamoa based devices, so I reserved it
> on all.
Such leaps of faith comes down to risk vs reward; the risk seems
reasonable, but your commit message just states a fact not a problem -
so there's no documented reward...
Regards,
Bjorn
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Abel Vesa (9):
> arm64: dts: qcom: x1-crd: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e001de-devkit: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e78100-t14s: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-dell-xps13-9345: Mark the EC reset gpio as reserved
> arm64: dts: qcom: honor-magicbook-art-14: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-yoga-slim7x: Mark the EC reset gpio as reserved
> arm64: dts: qcom: medion-sprchrgd-14-s1: Mark the EC reset gpio as reserved
> arm64: dts: qcom: microsoft-romulus: Mark the EC reset gpio as reserved
> arm64: dts: qcom: x1e80100-qcp: Mark the EC reset gpio as reserved
>
> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 ++-
> arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts | 3 ++-
> arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 +
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 +
> 9 files changed, 11 insertions(+), 2 deletions(-)
> ---
> base-commit: e30626823a406725ce29bc75cb8ec467d3e1e326
> change-id: 20260831-dts-qcom-hamoa-reserve-ec-reset-gpio-0bf57fbd24e7
>
> Best regards,
> --
> Abel Vesa <abel.vesa@oss.qualcomm.com>
>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 0/9] arm64: dts: qcom: hamoa: Mark the EC reset gpio as reserved on all boards
2026-08-31 15:07 ` Bjorn Andersson
@ 2026-08-31 15:34 ` Abel Vesa
0 siblings, 0 replies; 17+ messages in thread
From: Abel Vesa @ 2026-08-31 15:34 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sibi Sankar, Abel Vesa, Rajendra Nayak, Marc Zyngier,
Aleksandrs Vinarskis, Konstantin Shabanov, Srinivas Kandagatla,
Georg Gottleuber, Ettore Chimenti, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Konrad Dybcio
On 26-08-31 10:07:31, Bjorn Andersson wrote:
> On Mon, Aug 31, 2026 at 12:54:40PM +0300, Abel Vesa wrote:
> > GPIO 65 from TLMM is used by the embedded controller as its reset line on
> > these boards. Reserve it to prevent Linux from requesting or reconfiguring it.
> >
> > I was only able to confirm that this GPIO is actually connected to the
> > EC reset on the CRD, QCP, xps13 and t14s. But it seems like it is
> > recurring them shared between all Hamoa based devices, so I reserved it
> > on all.
>
> Such leaps of faith comes down to risk vs reward; the risk seems
> reasonable, but your commit message just states a fact not a problem -
> so there's no documented reward...
So I actually considered adding a sentence that would mention that on
some of these devices, if you play with EC reset gpio, you might have to
disassemble the device and unplug the battery, in order to be able to
use it again. But I'm not sure that is applicable to all devices.
All I know, from someone else's experience, is that we should not be
controlling that from linux. Therefore, the commit message did not
make any assumptions about what the "reward" is.
However, I can add such a line if you still think it is worth it.
^ permalink raw reply [flat|nested] 17+ messages in thread