mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "John Ogness" <john.ogness@linutronix.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	"Thierry Reding" <thierry.reding@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Crescent Hsieh" <crescentcy.hsieh@moxa.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH tty 1/1] serial: 8250: Change console_msr_work to IRQ_WORK_LAZY
Date: Mon, 31 Aug 2026 17:23:54 +0200	[thread overview]
Message-ID: <apWcikIof_6CRNNU@pathway.suse.cz> (raw)
In-Reply-To: <20260828160652.TQBsi8oO@linutronix.de>

On Fri 2026-08-28 18:06:52, Sebastian Andrzej Siewior wrote:
> On 2026-08-28 18:04:08 [+0206], John Ogness wrote:
> > For some platforms it is a problem to queue irq_work when entering
> > cpuidle states. Since irq_work is used for deferred MSR handling,
> > any atomic console printing when entering cpuidle states can lead
> > to the affected hardware hanging. Tegra20 and Tegra30 are examples
> > of such platforms. Avoiding raising the irq_work IRQ has shown to
> > circumvent the problem.
> 
> > Change the console_msr_work to be IRQ_WORK_LAZY, thus not raising
> > an IRQ upon irq_work queuing. The irq_work is then handled on the
> > next interrupt (worst case, kernel tick).
>
> Not on the next interrupt, on the next jiffies tick. Should you run
> tickless and should the CPU have the tick switch off then it will raise
> the irq-work interrupt anyway.

This seems to be more precise. There is one more scenario. It would
run in a dedicated kthread with PREEMPT_RT.

I hope that nobody would run tickless system on the old
Tegra hardware. So, this change should be good enough in reality.

Anyway, I would prefer to get this "workaround" in for 7.3.
In each case, I would not want to revert the uart 8250 conversion
to nbcon because it did break the Tegra hardware.

Best Regards,
Petr

  parent reply	other threads:[~2026-08-31 15:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:58 [PATCH tty 0/1] Make 8250 deferred MSR handling LAZY John Ogness
2026-08-28 15:58 ` [PATCH tty 1/1] serial: 8250: Change console_msr_work to IRQ_WORK_LAZY John Ogness
2026-08-28 16:06   ` Sebastian Andrzej Siewior
2026-08-28 16:41     ` John Ogness
2026-08-28 17:06     ` Jon Hunter
2026-08-30  7:42       ` Andy Shevchenko
2026-08-31  8:20       ` Sebastian Andrzej Siewior
2026-09-01  9:20         ` Jon Hunter
2026-08-31 15:23     ` Petr Mladek [this message]
2026-09-01  7:50       ` Sebastian Andrzej Siewior
2026-09-02  8:34   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apWcikIof_6CRNNU@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=crescentcy.hsieh@moxa.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®